FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add test for accessing read-only mmapped data in a core file

Browse source 
This test passes when run using a GDB with my corefile patches.  When
run against a GDB without my patches, I see the following failures,
the first of which is due to the test added by this commit:

FAIL: gdb.base/corefile.exp: accessing read-only mmapped data in core file (mapping address not found in core file)
FAIL: gdb.base/corefile.exp: accessing anonymous, unwritten-to mmap data

gdb/testsuite/ChangeLog:

	* gdb.base/corefile.exp: Add test "accessing read-only mmapped
	data in core file".
	* gdb.base/coremaker.c (buf2ro): New global.
	(mmapdata): Add a read-only mmap mapping.
This commit is contained in:
Kevin Buettner 2020-06-16 11:39:22 -07:00
parent db082f5979
commit f9e233c9c4
3 changed files with 36 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gdb/testsuite/ChangeLog
View file

@ -1,3 +1,10 @@
2020-07-22 Kevin Buettner <kevinb@redhat.com>
* gdb.base/corefile.exp: Add test "accessing read-only mmapped
data in core file".
* gdb.base/coremaker.c (buf2ro): New global.
(mmapdata): Add a read-only mmap mapping.
2020-07-22 Kevin Buettner <kevinb@redhat.com>
PR corefiles/25631

18
gdb/testsuite/gdb.base/corefile.exp
View file

@ -34,7 +34,10 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
return -1
}
set corefile [core_find $binfile {coremmap.data}]
# Do not delete coremap.data when calling core_find. This file is
# required for GDB to find mmap'd data in the "accessing read-only
# mmapped data in core file" test.
set corefile [core_find $binfile {}]
if {$corefile == ""} {
return 0
}
@ -175,6 +178,19 @@ gdb_test_multiple "x/8bd buf2" "$test" {
}
}
set test "accessing read-only mmapped data in core file"
gdb_test_multiple "x/8bd buf2ro" "$test" {
-re ".*:.*0.*1.*2.*3.*4.*5.*6.*7.*$gdb_prompt $" {
pass "$test"
}
-re "0x\[f\]*:.*Cannot access memory at address 0x\[f\]*.*$gdb_prompt $" {
fail "$test (mapping failed at runtime)"
}
-re "0x.*:.*Cannot access memory at address 0x.*$gdb_prompt $" {
fail "$test (mapping address not found in core file)"
}
}
# Test ability to read anonymous and, more importantly, unwritten-to
# mmap'd data.

14
gdb/testsuite/gdb.base/coremaker.c
View file

@ -38,6 +38,7 @@
char *buf1;
char *buf2;
char *buf2ro;
char *buf3;
int coremaker_data = 1; /* In Data section */
@ -90,16 +91,25 @@ mmapdata ()
return;
}
/* Map in another copy, read-only. We won't write to this copy so it
will likely not end up in the core file. */
buf2ro = (char *) mmap (0, MAPSIZE, PROT_READ, MAP_PRIVATE, fd, 0);
if (buf2ro == (char *) -1)
{
perror ("mmap failed");
return;
}
/* Verify that the original data and the mapped data are identical.
If not, we'd rather fail now than when trying to access the mapped
data from the core file. */
for (j = 0; j < MAPSIZE; ++j)
{
if (buf1[j] != buf2[j])
if (buf1[j] != buf2[j] || buf1[j] != buf2ro[j])
{
fprintf (stderr, "mapped data is incorrect");
buf2 = (char *) -1;
buf2 = buf2ro = (char *) -1;
return;
}
}