FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

GDB crash with empty executable name (MinGW).

Browse source 
* source.c (openp): Add assert that parameter string is not NULL.
        if parameter string is an empty string, then return with a failure
        immediately.
This commit is contained in:
Joel Brobecker 2010-01-08 13:54:40 +00:00
parent 2de75e717c
commit f91e5ac34e
2 changed files with 21 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

14
gdb/source.c
View file

@ -707,6 +707,20 @@ openp (const char *path, int opts, const char *string,
/* The open syscall MODE parameter is not specified. */
gdb_assert ((mode & O_CREAT) == 0);
gdb_assert (string != NULL);
/* A file with an empty name cannot possibly exist. Report a failure
without further checking.
This is an optimization which also defends us against buggy
implementations of the "stat" function. For instance, we have
noticed that a MinGW debugger built on Windows XP 32bits crashes
when the debugger is started with an empty argument. */
if (string[0] == '\0')
{
errno = ENOENT;
return -1;
}
if (!path)
path = ".";