FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

write_pieced_value: Notify memory_changed observers

Browse source 
So far write_pieced_value uses write_memory when writing memory pieces to
the target.  However, this is a case where GDB potentially overwrites a
watchpoint value.  In such a case write_memory_with_notification should be
used instead, so that memory_changed observers get notified.

gdb/ChangeLog:

	* dwarf2loc.c (write_pieced_value): When writing the data for a
	memory piece, use write_memory_with_notification instead of
	write_memory.
This commit is contained in:
Andreas Arnez 2017-06-13 15:20:32 +02:00
parent 23f945bf8c
commit f65e204425
2 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gdb/ChangeLog
View file

@ -1,3 +1,9 @@
2017-06-13 Andreas Arnez <arnez@linux.vnet.ibm.com>
* dwarf2loc.c (write_pieced_value): When writing the data for a
memory piece, use write_memory_with_notification instead of
write_memory.
2017-06-13 Andreas Arnez <arnez@linux.vnet.ibm.com>
* valops.c (read_value_memory): Change embedded_offset to

9
gdb/dwarf2loc.c
View file

@ -2025,9 +2025,9 @@ write_pieced_value (struct value *to, struct value *from)
&& offset % 8 == 0)
{
/* Everything is byte-aligned; no buffer needed. */
write_memory (start_addr,
contents + offset / 8,
this_size_bits / 8);
write_memory_with_notification (start_addr,
contents + offset / 8,
this_size_bits / 8);
break;
}
@ -2054,7 +2054,8 @@ write_pieced_value (struct value *to, struct value *from)
copy_bitwise (buffer.data (), bits_to_skip % 8,
contents, offset,
this_size_bits, bits_big_endian);
write_memory (start_addr, buffer.data (), this_size);
write_memory_with_notification (start_addr, buffer.data (),
this_size);
}
break;
default: