Fix use of a dangling pointer for Python breakpoint objects
When a Python script tries to create a breakpoint but fails to do so, gdb.Breakpoint.__init__ raises an exception and the breakpoint does not exist anymore in the Python interpreter. However, GDB still keeps a reference to the Python object to be used for a later hook, which is wrong. This commit adds the necessary cleanup code so that there is no stale reference to this Python object. It also adds a new testcase to reproduce the bug and check the fix. 2016-06-25 Pierre-Marie de Rodat <derodat@adacore.com> gdb/ * python/py-breakpoint.c (bppy_init): Clear bppy_pending_object when there is an error during the breakpoint creation. gdb/testsuite * gdb.python/py-breakpoint-create-fail.c, gdb.python/py-breakpoint-create-fail.exp, gdb.python/py-breakpoint-create-fail.py: New testcase.
This commit is contained in:
parent
3cd72572cb
commit
f495252396
6 changed files with 127 additions and 0 deletions
31
gdb/testsuite/gdb.python/py-breakpoint-create-fail.py
Normal file
31
gdb/testsuite/gdb.python/py-breakpoint-create-fail.py
Normal file
|
@ -0,0 +1,31 @@
|
|||
# Copyright (C) 2016 Free Software Foundation, Inc.
|
||||
#
|
||||
# This program is free software; you can redistribute it and/or modify
|
||||
# it under the terms of the GNU General Public License as published by
|
||||
# the Free Software Foundation; either version 3 of the License, or
|
||||
# (at your option) any later version.
|
||||
#
|
||||
# This program is distributed in the hope that it will be useful,
|
||||
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
# GNU General Public License for more details.
|
||||
#
|
||||
# You should have received a copy of the GNU General Public License
|
||||
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
import gdb
|
||||
|
||||
|
||||
class MyBP(gdb.Breakpoint):
|
||||
def stop(self):
|
||||
print('MyBP.stop was invoked!')
|
||||
# Don't make this breakpoint stop
|
||||
return False
|
||||
|
||||
|
||||
try:
|
||||
bp = MyBP('does_not_exist', gdb.BP_WATCHPOINT)
|
||||
except RuntimeError:
|
||||
pass
|
||||
else:
|
||||
assert False
|
Loading…
Add table
Add a link
Reference in a new issue