FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

use explicit returns to avoid checker confusion

Browse source 
The checker does not understand the idiom

if (except.reason < 0) {
   do_cleanups (whatever);
   GDB_PY_HANDLE_EXCEPTION (except);
}

because it doesn't realize that the nested 'if' actually has the same
condition.

This fixes instances of this to be more explicit.

	* python/py-breakpoint.c (bppy_get_commands): Use
	explicit, unconditional return.
	* python/py-frame.c (frapy_read_var): Likewise.
	* python/python.c (gdbpy_decode_line): Likewise.
This commit is contained in:
Tom Tromey 2013-05-30 17:30:03 +00:00
parent c27e16e3f1
commit f330038710
4 changed files with 13 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
gdb/python/py-breakpoint.c
View file

@ -492,7 +492,8 @@ bppy_get_commands (PyObject *self, void *closure)
if (except.reason < 0)
{
do_cleanups (chain);
GDB_PY_HANDLE_EXCEPTION (except);
gdbpy_convert_exception (except);
return NULL;
}
cmdstr = ui_file_xstrdup (string_file, &length);