FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdbserver: When attaching, add process before lwps

Browse source 
The recent BP/WP changes for AArch64 swapping the order in add_lwp()
so that the process was added before the lwp. This was due to the lwp
creation requiring the process data.

This also needs changing in linux_attach().

Fixes gdb.server/ext-attach.exp on Aarch64.

(This regression was hidden due to the racy nature of the gdb.server
tests - now they are no longer racy it'll be easier to spot. Also
checked X86).

gdb/gdbserver/ChangeLog:

2019-01-25  Alan Hayward  <alan.hayward@arm.com>

	* linux-low.c (linux_attach): Add process before lwp.
This commit is contained in:
Alan Hayward 2019-01-24 18:55:20 +00:00
parent f5f2b743ae
commit f084d33511
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gdb/gdbserver/linux-low.c
View file

@ -1188,6 +1188,8 @@ linux_attach (unsigned long pid)
ptid_t ptid = ptid_t (pid, pid, 0);
int err;
proc = linux_add_process (pid, 1);
/* Attach to PID. We will check for other threads
soon. */
err = linux_attach_lwp (ptid);
@ -1198,8 +1200,6 @@ linux_attach (unsigned long pid)
error ("Cannot attach to process %ld: %s", pid, reason.c_str ());
}
proc = linux_add_process (pid, 1);
/* Don't ignore the initial SIGSTOP if we just attached to this
process. It will be collected by wait shortly. */
initial_thread = find_thread_ptid (ptid_t (pid, pid, 0));