FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libctf: actually close bfds we have opened

Browse source 
When we do a ctf_fdopen, we open things via bfd_fdopenr and set up a
hook to close the bfd again... but then we never actually call that hook
from anywhere, so we eventually leak every bfd we open.

Fix this by calling the hook (if set) in ctf_arc_close.

New in v3.

libctf/
	* ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
	* ctf-open-bfd.c (ctf_bfdclose): Fix comment.
This commit is contained in:
Nick Alcock 2019-07-29 17:02:48 +01:00
parent edc8bbe90b
commit f046147d59
3 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
libctf/ChangeLog
View file

@ -1,3 +1,8 @@
2019-07-30 Nick Alcock <nick.alcock@oracle.com>
* ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
* ctf-open-bfd.c (ctf_bfdclose): Fix comment.
2019-07-30 Nick Alcock <nick.alcock@oracle.com>
* ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.

2
libctf/ctf-archive.c
View file

@ -436,6 +436,8 @@ ctf_arc_close (ctf_archive_t *arc)
free ((void *) arc->ctfi_symsect.cts_data);
/* Do not free the ctfi_strsect: it is bound to the bfd. */
free (arc->ctfi_data);
if (arc->ctfi_bfd_close)
arc->ctfi_bfd_close (arc);
free (arc);
}

2
libctf/ctf-open-bfd.c
View file

@ -66,7 +66,7 @@ ctf_new_archive_internal (int is_archive, struct ctf_archive *arc,
return arci;
}
/* Free the BFD bits of a CTF file on ctf_file_close(). */
/* Free the BFD bits of a CTF file on ctf_arc_close(). */
static void
ctf_bfdclose (struct ctf_archive_internal *arci)