FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

x86: don't accept base architectures as extensions

Browse source 
The -march= intentions are quite clear: A base architecture may be
followed by any number of extensions. Accepting a base architecture in
place of an extension will at best result in confusion, as the first of
the two (or more) items specified simply would not take effect, due to
being overridden by the later one(s).
This commit is contained in:
Jan Beulich 2022-03-17 11:05:56 +01:00
parent 13ed231a0f
commit ed971d9fa6
4 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gas/config/tc-i386.c
View file

@ -13262,7 +13262,7 @@ md_parse_option (int c, const char *arg)
*next++ = '\0';
for (j = 0; j < ARRAY_SIZE (cpu_arch); j++)
{
if (strcmp (arch, cpu_arch [j].name) == 0)
if (arch == saved && strcmp (arch, cpu_arch [j].name) == 0)
{
/* Processor. */
if (! cpu_arch[j].flags.bitfield.cpui386)

2
gas/testsuite/gas/i386/arch-10-5.l Normal file
View file

@ -0,0 +1,2 @@
Assembler messages:
Fatal error: .*

1
gas/testsuite/gas/i386/arch-10-5.s Normal file
View file

@ -0,0 +1 @@
.text

1
gas/testsuite/gas/i386/i386.exp
View file

@ -199,6 +199,7 @@ if [gas_32_check] then {
run_list_test "arch-10-2" "-march=i686 -I${srcdir}/$subdir -al"
run_list_test "arch-10-3" "-march=i686+mmx+sse4.2 -I${srcdir}/$subdir -al"
run_list_test "arch-10-4" "-march=i686+mmx+sse4+vmx+smx -I${srcdir}/$subdir -al"
run_list_test "arch-10-5" "-march=generic32+i686 -al"
run_dump_test "arch-11"
run_dump_test "arch-12"
run_dump_test "arch-13"