FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb: don't handle old == nullptr in add_alias_cmd

Browse source 
I don't think this can ever happen, that we add an alias command and
pass a nullptr old (target) command.  Remove the "if" handling this,
replace with an assert.

gdb/ChangeLog:

	* cli/cli-decode.c (add_alias_cmd): Don't handle old == 0.

Change-Id: Ibb39e8dc4e0c465fa42e6826215f30a0a0aef932
This commit is contained in:
Simon Marchi 2021-05-17 14:01:01 -04:00
parent 413b49c2b6
commit ecd0a6b35d
2 changed files with 5 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

4
gdb/ChangeLog
View file

@ -1,3 +1,7 @@
2021-05-17 Simon Marchi <simon.marchi@polymtl.ca>
* cli/cli-decode.c (add_alias_cmd): Don't handle old == 0.
2021-05-17 Simon Marchi <simon.marchi@polymtl.ca>
* cli/cli-decode.h (prefixname): Make const, move implementation

13
gdb/cli/cli-decode.c
View file

@ -310,18 +310,7 @@ add_alias_cmd (const char *name, cmd_list_element *old,
enum command_class theclass, int abbrev_flag,
struct cmd_list_element **list)
{
if (old == 0)
{
struct cmd_list_element *prehook, *prehookee, *posthook, *posthookee;
struct cmd_list_element *aliases = delete_cmd (name, list,
&prehook, &prehookee,
&posthook, &posthookee);
/* If this happens, it means a programmer error somewhere. */
gdb_assert (!aliases && !prehook && !prehookee
&& !posthook && ! posthookee);
return 0;
}
gdb_assert (old != nullptr);
struct cmd_list_element *c = add_cmd (name, theclass, old->doc, list);