FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

2003-04-06 Andrew Cagney <cagney@redhat.com>

Browse source 
* frame.h (legacy_frame_chain_valid): Rename frame_chain_valid.
	Update comment.
	* frame.c (legacy_saved_regs_this_id): Update.
	(legacy_get_prev_frame): Update.
	* xstormy16-tdep.c: Update comment.
	* sparc-tdep.c (sparc_frame_chain): Update comment.
	* blockframe.c (legacy_frame_chain_valid): Update.
This commit is contained in:
Andrew Cagney 2003-04-06 18:36:23 +00:00
parent 996179eebb
commit e6ba3bc976
6 changed files with 36 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

21
gdb/sparc-tdep.c
View file

@ -437,16 +437,17 @@ sparc_frame_chain (struct frame_info *frame)
about the chain value. If it really is zero, we detect it later
in sparc_init_prev_frame.
Note: kevinb/2003-02-18: The constant 1 used to be returned
here, but, after some recent changes to frame_chain_valid(),
this value is no longer suitable for causing frame_chain_valid()
to "not worry about the chain value." The constant ~0 (i.e,
0xfff...) causes the failing test in frame_chain_valid() to
succeed thus preserving the "not worry" property. I had considered
using something like ``get_frame_base (frame) + 1''. However, I think
a constant value is better, because when debugging this problem,
I knew that something funny was going on as soon as I saw the
constant 1 being used as the frame chain elsewhere in GDB. */
Note: kevinb/2003-02-18: The constant 1 used to be returned here,
but, after some recent changes to legacy_frame_chain_valid(),
this value is no longer suitable for causing
legacy_frame_chain_valid() to "not worry about the chain value."
The constant ~0 (i.e, 0xfff...) causes the failing test in
legacy_frame_chain_valid() to succeed thus preserving the "not
worry" property. I had considered using something like
``get_frame_base (frame) + 1''. However, I think a constant
value is better, because when debugging this problem, I knew that
something funny was going on as soon as I saw the constant 1
being used as the frame chain elsewhere in GDB. */
return ~ (CORE_ADDR) 0;
}