FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove unused parameter in solib_add and update_solib_list

Browse source 
The target parameter in both solib_add and update_solib_list
functions is not used anymore and as not been used for a while. This
change removes the parameter to clean up the code a little bit.

gdb/ChangeLog:

	* infcmd.c (post_create_inferior): Remove unused argument in
	call to solib_add.
	* remote.c (remote_start_remote): Likewise.
	* solib-frv.c (frv_fetch_objfile_link_map): Likewise.
	* solib-svr4.c: (svr4_fetch_objfile_link_map): Likewise.
	(enable_break): Likewise.
	* solib.c (update_solib_list): Remove unused target argument
	and its documentation.
	(solib_add): Remove unused target argument.  Remove unused
	argument in call to update_solib_list.
	(info_sharedlibrary_command): Remove unused argument in call
	to update_solib_list.
	(sharedlibrary_command): Remove unused argument in call to
	solib_add.
	(handle_solib_event): Likewise.
	(reload_shared_libraries): Likewise.
	* solib.h (solib_add): Remove unused target argument.

Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
This commit is contained in:
Marc-Andre Laperle 2017-03-20 14:57:32 -04:00
parent 59a561480d
commit e696b3ad34
7 changed files with 37 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

20
gdb/ChangeLog
View file

@ -1,3 +1,23 @@
2017-03-20 Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
* infcmd.c (post_create_inferior): Remove unused argument in
call to solib_add.
* remote.c (remote_start_remote): Likewise.
* solib-frv.c (frv_fetch_objfile_link_map): Likewise.
* solib-svr4.c: (svr4_fetch_objfile_link_map): Likewise.
(enable_break): Likewise.
* solib.c (update_solib_list): Remove unused target argument
and its documentation.
(solib_add): Remove unused target argument. Remove unused
argument in call to update_solib_list.
(info_sharedlibrary_command): Remove unused argument in call
to update_solib_list.
(sharedlibrary_command): Remove unused argument in call to
solib_add.
(handle_solib_event): Likewise.
(reload_shared_libraries): Likewise.
* solib.h (solib_add): Remove unused target argument.
2017-03-20 Andreas Arnez <arnez@linux.vnet.ibm.com> 2017-03-20 Andreas Arnez <arnez@linux.vnet.ibm.com>
* s390-linux-tdep.c (is_rsi, is_rie): Remove functions. * s390-linux-tdep.c (is_rsi, is_rie): Remove functions.

2
gdb/infcmd.c
View file

@ -458,7 +458,7 @@ post_create_inferior (struct target_ops *target, int from_tty)
/* If the solist is global across processes, there's no need to /* If the solist is global across processes, there's no need to
refetch it here. */ refetch it here. */
if (!gdbarch_has_global_solist (target_gdbarch ())) if (!gdbarch_has_global_solist (target_gdbarch ()))
solib_add (NULL, 0, target, auto_solib_add); solib_add (NULL, 0, auto_solib_add);
} }
} }

2
gdb/remote.c
View file

@ -4142,7 +4142,7 @@ remote_start_remote (int from_tty, struct target_ops *target, int extended_p)
/* On OSs where the list of libraries is global to all /* On OSs where the list of libraries is global to all
processes, we fetch them early. */ processes, we fetch them early. */
if (gdbarch_has_global_solist (target_gdbarch ())) if (gdbarch_has_global_solist (target_gdbarch ()))
solib_add (NULL, from_tty, target, auto_solib_add); solib_add (NULL, from_tty, auto_solib_add);
if (target_is_non_stop_p ()) if (target_is_non_stop_p ())
{ {

2
gdb/solib-frv.c
View file

@ -1131,7 +1131,7 @@ frv_fetch_objfile_link_map (struct objfile *objfile)
/* Cause frv_current_sos() to be run if it hasn't been already. */ /* Cause frv_current_sos() to be run if it hasn't been already. */
if (main_lm_addr == 0) if (main_lm_addr == 0)
solib_add (0, 0, 0, 1); solib_add (0, 0, 1);
/* frv_current_sos() will set main_lm_addr for the main executable. */ /* frv_current_sos() will set main_lm_addr for the main executable. */
if (objfile == symfile_objfile) if (objfile == symfile_objfile)

6
gdb/solib-svr4.c
View file

@ -1618,7 +1618,7 @@ svr4_fetch_objfile_link_map (struct objfile *objfile)
/* Cause svr4_current_sos() to be run if it hasn't been already. */ /* Cause svr4_current_sos() to be run if it hasn't been already. */
if (info->main_lm_addr == 0) if (info->main_lm_addr == 0)
solib_add (NULL, 0, &current_target, auto_solib_add); solib_add (NULL, 0, auto_solib_add);
/* svr4_current_sos() will set main_lm_addr for the main executable. */ /* svr4_current_sos() will set main_lm_addr for the main executable. */
if (objfile == symfile_objfile) if (objfile == symfile_objfile)
@ -2277,7 +2277,7 @@ enable_break (struct svr4_info *info, int from_tty)
mean r_brk has already been relocated. Assume the dynamic linker mean r_brk has already been relocated. Assume the dynamic linker
is the object containing r_brk. */ is the object containing r_brk. */
solib_add (NULL, from_tty, &current_target, auto_solib_add); solib_add (NULL, from_tty, auto_solib_add);
sym_addr = 0; sym_addr = 0;
if (info->debug_base && solib_svr4_r_map (info) != 0) if (info->debug_base && solib_svr4_r_map (info) != 0)
sym_addr = solib_svr4_r_brk (info); sym_addr = solib_svr4_r_brk (info);
@ -2453,7 +2453,7 @@ enable_break (struct svr4_info *info, int from_tty)
info->debug_loader_name = xstrdup (interp_name); info->debug_loader_name = xstrdup (interp_name);
info->debug_loader_offset_p = 1; info->debug_loader_offset_p = 1;
info->debug_loader_offset = load_addr; info->debug_loader_offset = load_addr;
solib_add (NULL, from_tty, &current_target, auto_solib_add); solib_add (NULL, from_tty, auto_solib_add);
} }
/* Record the relocated start and end address of the dynamic linker /* Record the relocated start and end address of the dynamic linker

28
gdb/solib.c
View file

@ -763,17 +763,10 @@ solib_used (const struct so_list *const known)
to the list, and leave their symbols_loaded flag clear. to the list, and leave their symbols_loaded flag clear.
If FROM_TTY is non-null, feel free to print messages about what If FROM_TTY is non-null, feel free to print messages about what
we're doing. we're doing. */
If TARGET is non-null, add the sections of all new shared objects void
to TARGET's section table. Note that this doesn't remove any update_solib_list (int from_tty)
sections for shared objects that have been unloaded, and it
doesn't check to see if the new shared objects are already present in
the section table. But we only use this for core files and
processes we've just attached to, so that's okay. */
static void
update_solib_list (int from_tty, struct target_ops *target)
{ {
const struct target_so_ops *ops = solib_ops (target_gdbarch ()); const struct target_so_ops *ops = solib_ops (target_gdbarch ());
struct so_list *inferior = ops->current_sos(); struct so_list *inferior = ops->current_sos();
@ -974,11 +967,10 @@ libpthread_solib_p (struct so_list *so)
If READSYMS is 0, defer reading symbolic information until later If READSYMS is 0, defer reading symbolic information until later
but still do any needed low level processing. but still do any needed low level processing.
FROM_TTY and TARGET are as described for update_solib_list, above. */ FROM_TTY is described for update_solib_list, above. */
void void
solib_add (const char *pattern, int from_tty, solib_add (const char *pattern, int from_tty, int readsyms)
struct target_ops *target, int readsyms)
{ {
struct so_list *gdb; struct so_list *gdb;
@ -1003,7 +995,7 @@ solib_add (const char *pattern, int from_tty,
error (_("Invalid regexp: %s"), re_err); error (_("Invalid regexp: %s"), re_err);
} }
update_solib_list (from_tty, target); update_solib_list (from_tty);
/* Walk the list of currently loaded shared libraries, and read /* Walk the list of currently loaded shared libraries, and read
symbols for any that match the pattern --- or any whose symbols symbols for any that match the pattern --- or any whose symbols
@ -1086,7 +1078,7 @@ info_sharedlibrary_command (char *pattern, int from_tty)
/* "0x", a little whitespace, and two hex digits per byte of pointers. */ /* "0x", a little whitespace, and two hex digits per byte of pointers. */
addr_width = 4 + (gdbarch_ptr_bit (gdbarch) / 4); addr_width = 4 + (gdbarch_ptr_bit (gdbarch) / 4);
update_solib_list (from_tty, 0); update_solib_list (from_tty);
/* make_cleanup_ui_out_table_begin_end needs to know the number of /* make_cleanup_ui_out_table_begin_end needs to know the number of
rows, so we need to make two passes over the libs. */ rows, so we need to make two passes over the libs. */
@ -1276,7 +1268,7 @@ static void
sharedlibrary_command (char *args, int from_tty) sharedlibrary_command (char *args, int from_tty)
{ {
dont_repeat (); dont_repeat ();
solib_add (args, from_tty, (struct target_ops *) 0, 1); solib_add (args, from_tty, 1);
} }
/* Implements the command "nosharedlibrary", which discards symbols /* Implements the command "nosharedlibrary", which discards symbols
@ -1323,7 +1315,7 @@ handle_solib_event (void)
be adding them automatically. Switch terminal for any messages be adding them automatically. Switch terminal for any messages
produced by breakpoint_re_set. */ produced by breakpoint_re_set. */
target_terminal_ours_for_output (); target_terminal_ours_for_output ();
solib_add (NULL, 0, &current_target, auto_solib_add); solib_add (NULL, 0, auto_solib_add);
target_terminal_inferior (); target_terminal_inferior ();
} }
@ -1441,7 +1433,7 @@ reload_shared_libraries (char *ignored, int from_tty,
removed. Call it only after the solib target has been initialized by removed. Call it only after the solib target has been initialized by
solib_create_inferior_hook. */ solib_create_inferior_hook. */
solib_add (NULL, 0, NULL, auto_solib_add); solib_add (NULL, 0, auto_solib_add);
breakpoint_re_set (); breakpoint_re_set ();

2
gdb/solib.h
View file

@ -35,7 +35,7 @@ extern void clear_solib (void);
/* Called to add symbols from a shared library to gdb's symbol table. */ /* Called to add symbols from a shared library to gdb's symbol table. */
extern void solib_add (const char *, int, struct target_ops *, int); extern void solib_add (const char *, int, int);
extern int solib_read_symbols (struct so_list *, symfile_add_flags); extern int solib_read_symbols (struct so_list *, symfile_add_flags);
/* Function to be called when the inferior starts up, to discover the /* Function to be called when the inferior starts up, to discover the