FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb: replace some calls to internal_error with gdb_assert

Browse source 
There are a few spots using the pattern:

  if (condition)
    internal_error (__FILE__, __LINE__,
		    _("failed internal consistency check"));

The message brings no value, since it's pretty the description of a
failed assertion.  Replace a few of these that are obvious with
gdb_assert.

gdb/ChangeLog:

	* exec.c (build_section_table): Replace internal_error with
	gdb_assert.
	(section_table_xfer_memory_partial): Likewise.
	* mdebugread.c (parse_partial_symbols): Likewise.
	* psymtab.c (lookup_partial_symbol): Likewise.
	* utils.c (wrap_here): Likewise.
This commit is contained in:
Simon Marchi 2020-04-02 15:43:41 -04:00
parent 0830d30190
commit e2ff18a0a5
5 changed files with 21 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

11
gdb/psymtab.c
View file

@ -683,9 +683,9 @@ lookup_partial_symbol (struct objfile *objfile,
while (top > bottom)
{
center = bottom + (top - bottom) / 2;
if (!(center < top))
internal_error (__FILE__, __LINE__,
_("failed internal consistency check"));
gdb_assert (center < top);
if (strcmp_iw_ordered ((*center)->ginfo.search_name (),
lookup_name.c_str ()) >= 0)
{
@ -696,9 +696,8 @@ lookup_partial_symbol (struct objfile *objfile,
bottom = center + 1;
}
}
if (!(top == bottom))
internal_error (__FILE__, __LINE__,
_("failed internal consistency check"));
gdb_assert (top == bottom);
/* For `case_sensitivity == case_sensitive_off' strcmp_iw_ordered will
search more exactly than what matches SYMBOL_MATCHES_SEARCH_NAME. */