FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

* ser-go32.c (dos_get_tty_state): Fail if the (fake) handle was

Browse source 
not opened by dos_open, but let the 3 standard handles go through
unharmed.
This commit is contained in:
Eli Zaretskii 2000-03-15 11:10:52 +00:00
parent 10982c59de
commit dfed996b3b
1 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
gdb/ser-go32.c
View file

@ -488,6 +488,10 @@ dos_open (scb, name)
return -1; return -1;
} }
/* FIXME: this is a Bad Idea (tm)! One should *never* invent file
handles, since they might be already used by other files/devices.
The Right Way to do this is to create a real handle by dup()'ing
some existing one. */
fd = name[3] - '1'; fd = name[3] - '1';
port = &ports[fd]; port = &ports[fd];
if (port->refcnt++ > 0) if (port->refcnt++ > 0)
@ -650,6 +654,19 @@ dos_get_tty_state (scb)
struct dos_ttystate *port = &ports[scb->fd]; struct dos_ttystate *port = &ports[scb->fd];
struct dos_ttystate *state; struct dos_ttystate *state;
/* Are they asking about a port we opened? */
if (port->refcnt <= 0)
{
/* We've never heard about this port. We should fail this call,
unless they are asking about one of the 3 standard handles,
in which case we pretend the handle was open by us if it is
connected to a terminal device. This is beacuse Unix
terminals use the serial interface, so GDB expects the
standard handles to go through here. */
if (scb->fd >= 3 || !isatty (scb->fd))
return NULL;
}
state = (struct dos_ttystate *) xmalloc (sizeof *state); state = (struct dos_ttystate *) xmalloc (sizeof *state);
*state = *port; *state = *port;
return (serial_ttystate) state; return (serial_ttystate) state;