FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[gdb/testsuite] Use pie/nopie instead of ldflags=-pie/-no-pie

Browse source 
I noticed two test-case that use ldflags=-pie and ldflags-no-pie, instead of
the canonical pie and nopie options, which would typically also add
additional_flags=-fPIE respectively additional_flags=-fno-pie.

There is no indication that this is on purpose, so replace these with pie and
nopie.

Tested on x86_64-linux.
This commit is contained in:
Tom de Vries 2021-09-24 12:39:14 +02:00
parent b4e4386a2e
commit dbb17692ec
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
gdb/testsuite/gdb.base/load-command.exp
View file

@ -20,7 +20,7 @@ standard_testfile
# Disable generation of position independent executable (PIE). Otherwise, we # Disable generation of position independent executable (PIE). Otherwise, we
# would have to manually specify an offset to load. # would have to manually specify an offset to load.
set opts {debug ldflags=-no-pie} set opts {debug nopie}
if [prepare_for_testing "failed to prepare" $testfile $srcfile $opts] { if [prepare_for_testing "failed to prepare" $testfile $srcfile $opts] {
return -1 return -1

2
gdb/testsuite/gdb.dwarf2/fission-loclists-pie.exp
View file

@ -40,7 +40,7 @@ standard_testfile .S
set obj [standard_output_file "${testfile}.o"] set obj [standard_output_file "${testfile}.o"]
set dwo [standard_output_file "${testfile}.dwo"] set dwo [standard_output_file "${testfile}.dwo"]
if [build_executable_and_dwo_files "$testfile.exp" "${binfile}" \ if [build_executable_and_dwo_files "$testfile.exp" "${binfile}" \
{nodebug ldflags=-pie} \ {nodebug pie} \
[list $srcfile [list nodebug split-dwo additional_flags=-DDWO=\"$dwo\"] \ [list $srcfile [list nodebug split-dwo additional_flags=-DDWO=\"$dwo\"] \
$obj]] { $obj]] {
return -1 return -1