FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libsframe: avoid using magic number

Browse source 
Define a new constant for the maximum number of stack offsets handled in
libsframe, and use it.  Note that the SFrame format does not define such
a constant (limit).  This is an implmentation-defined constant in
libsframe.

include/
	* sframe-api.h (MAX_NUM_STACK_OFFSETS): New definition.
libsframe/
	* sframe.c (sframe_fre_sanity_check_p): Use it.
This commit is contained in:
Indu Bhagat 2023-06-01 09:41:04 -07:00
parent a5ffdcafc7
commit d987df5c95
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
include/sframe-api.h
View file

@ -31,7 +31,10 @@ extern "C"
typedef struct sframe_decoder_ctx sframe_decoder_ctx;
typedef struct sframe_encoder_ctx sframe_encoder_ctx;
#define MAX_OFFSET_BYTES (SFRAME_FRE_OFFSET_4B * 2 * 3)
#define MAX_NUM_STACK_OFFSETS 3
#define MAX_OFFSET_BYTES \
((SFRAME_FRE_OFFSET_4B * 2 * MAX_NUM_STACK_OFFSETS))
/* User interfacing SFrame Row Entry.
An abstraction provided by libsframe so the consumer is decoupled from

2
libsframe/sframe.c
View file

@ -299,7 +299,7 @@ sframe_fre_sanity_check_p (sframe_frame_row_entry *frep)
return false;
offset_cnt = sframe_fre_get_offset_count (fre_info);
if (offset_cnt > 3)
if (offset_cnt > MAX_NUM_STACK_OFFSETS)
return false;
return true;