FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

This is a simple bug. target_disable_btrace and target_teardown_btrace,

Browse source 
both from gdb/target.c, do a "return" calling another function.  But both
are marked as void.  Despite the fact that the functions being called are
void as well, this is wrong.  This patch fixes this by calling the functions
and then returning in the next line.

2013-10-16  Sergio Durigan Junior  <sergiodj@redhat.com>

	PR gdb/16042
	* target.c (target_disable_btrace): Fix invalid return value for
	void function.
	(target_teardown_btrace): Likewise.
This commit is contained in:
Sergio Durigan Junior 2013-10-16 02:41:42 +00:00
parent 26505cc0c4
commit d92f7ee31f
2 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
gdb/ChangeLog
View file

@ -1,3 +1,10 @@
2013-10-16 Sergio Durigan Junior <sergiodj@redhat.com>
PR gdb/16042
* target.c (target_disable_btrace): Fix invalid return value for
void function.
(target_teardown_btrace): Likewise.
2013-10-14 Yao Qi <yao@codesourcery.com>
* varobj.c (struct varobj): Move most of the fields to

10
gdb/target.c
View file

@ -4165,7 +4165,10 @@ target_disable_btrace (struct btrace_target_info *btinfo)
for (t = current_target.beneath; t != NULL; t = t->beneath)
if (t->to_disable_btrace != NULL)
return t->to_disable_btrace (btinfo);
{
t->to_disable_btrace (btinfo);
return;
}
tcomplain ();
}
@ -4179,7 +4182,10 @@ target_teardown_btrace (struct btrace_target_info *btinfo)
for (t = current_target.beneath; t != NULL; t = t->beneath)
if (t->to_teardown_btrace != NULL)
return t->to_teardown_btrace (btinfo);
{
t->to_teardown_btrace (btinfo);
return;
}
tcomplain ();
}