FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb: add assert in cmd_list_element::set_context

Browse source 
If something tries to set a context pointer on a cmd_list_element and
m_context is not nullptr, it's likely that two parts of the code are
trying to set different contexts, and one will overwrite the other.
This is almost guaranteed to lead to bad behavior or a crash, as one of
the spots will not be using the data it expects.  This happened to me
during development, so I think having this assert would be useful to
catch this problem earlier.

gdb/ChangeLog:

	* cli/cli-decode.h (struct cmd_list_element) <set_context>: Add
	assert.

Change-Id: I1f2e9fda1bf2bec1b732c9b90e7d7910a97f2ac6
This commit is contained in:
Simon Marchi 2021-06-25 21:38:51 -04:00
parent 0f8e203412
commit d6ff04a343
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2021-06-25 Simon Marchi <simon.marchi@polymtl.ca>
* cli/cli-decode.h (struct cmd_list_element) <set_context>: Add
assert.
2021-06-25 Simon Marchi <simon.marchi@polymtl.ca>
* cli/cli-decode.h (struct cmd_list_element) <set_context,

5
gdb/cli/cli-decode.h
View file

@ -94,7 +94,10 @@ struct cmd_list_element
{ return this->func == nullptr; }
void set_context (void *context)
{ m_context = context; }
{
gdb_assert (m_context == nullptr);
m_context = context;
}
void *context () const
{ return m_context; }