FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use correct stream for process record output

Browse source 
The process record code often emits unfiltered output.  In some cases,
this output ought to go to gdb_stderr (but see below).  In other
cases, the output is guarded by a logging variable and so ought to go
to gdb_stdlog.  This patch makes these changes.

Note that in many cases, the output to stderr is followed by a
"return -1", which is how process record indicates an error.  It seems
to me that calling error here would be preferable, because, in many
cases, that's all the caller does when it sees a -1.  However, I
haven't made this change.

This is part of PR gdb/7233.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=7233
This commit is contained in:
Tom Tromey 2021-12-26 13:41:36 -07:00
parent 0fed74615b
commit d68510ac19
13 changed files with 113 additions and 84 deletions
Download patch file Download diff file Expand all files Collapse all files

7
gdb/amd64-linux-tdep.c
View file

@ -1496,9 +1496,10 @@ amd64_linux_syscall_record_common (struct regcache *regcache,
if (syscall_gdb == gdb_sys_no_syscall)
{
printf_unfiltered (_("Process record and replay target doesn't "
"support syscall number %s\n"),
pulongest (syscall_native));
fprintf_unfiltered (gdb_stderr,
_("Process record and replay target doesn't "
"support syscall number %s\n"),
pulongest (syscall_native));
return -1;
}
else