FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix "'operator new' should not return NULL" errors in testsuite

Browse source 
When running the testsuite with clang, gdb.linespec/cpls-ops.cc
fails to compile with the following errors:
  warning: 'operator new' should not return a null pointer unless
    it is declared 'throw()' or 'noexcept' [-Wnew-returns-null]
  warning: 'operator new[]' should not return a null pointer unless
    it is declared 'throw()' or 'noexcept' [-Wnew-returns-null]

This prevents the gdb.linespec/cpls-ops.exp testcase from executing.
This commit fixes.

gdb/testsuite/ChangeLog:

	* gdb.linespec/cpls-ops.cc (dummy): New static global.
	(test_op_new::operator new): Add return statement.
	(test_op_new_array::operator new[]): Likewise.
This commit is contained in:
Gary Benson 2020-05-28 14:18:36 +01:00
parent efcf5fb585
commit cee00f1715
2 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
gdb/testsuite/ChangeLog
View file

@ -1,3 +1,9 @@
2020-05-28 Gary Benson <gbenson@redhat.com>
* gdb.linespec/cpls-ops.cc (dummy): New static global.
(test_op_new::operator new): Add return statement.
(test_op_new_array::operator new[]): Likewise.
2020-05-27 Pedro Alves <palves@redhat.com>
* gdb.linespec/cp-completion-aliases.exp: Remove readline_is_used

6
gdb/testsuite/gdb.linespec/cpls-ops.cc
View file

@ -91,6 +91,8 @@ test_op_array::operator[] (T *t)
/* Code for operator new tests. */
static int dummy;
struct test_op_new
{
void *operator new (size_t);
@ -99,7 +101,7 @@ struct test_op_new
void *
test_op_new::operator new (size_t)
{
return NULL;
return &dummy;
}
/* Code for operator delete tests. */
@ -124,7 +126,7 @@ struct test_op_new_array
void *
test_op_new_array::operator new[] (size_t)
{
return NULL;
return &dummy;
}
/* Code for operator delete[] tests. */