FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Bug 23142, SIGSEGV in is_strip_section

Browse source 
PR 23142
	* objcopy.c (group_signature): Don't accept groups that use a
	symbol table other than the one we've read.
This commit is contained in:
Alan Modra 2018-05-07 22:41:47 +09:30
parent 7bd8862c3a
commit ce4ec1a9b6
2 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
binutils/ChangeLog
View file

@ -1,3 +1,9 @@
2018-05-07 Alan Modra <amodra@gmail.com>
PR 23142
* objcopy.c (group_signature): Don't accept groups that use a
symbol table other than the one we've read.
2018-04-30 Francois H. Theron <francois.theron@netronome.com> 2018-04-30 Francois H. Theron <francois.theron@netronome.com>
* readelf.c: Very basic support for EM_NFP and its section types. * readelf.c: Very basic support for EM_NFP and its section types.

9
binutils/objcopy.c
View file

@ -1211,14 +1211,13 @@ group_signature (asection *group)
return NULL; return NULL;
ghdr = &elf_section_data (group)->this_hdr; ghdr = &elf_section_data (group)->this_hdr;
if (ghdr->sh_link < elf_numsections (abfd)) if (ghdr->sh_link == elf_onesymtab (abfd))
{ {
const struct elf_backend_data *bed = get_elf_backend_data (abfd); const struct elf_backend_data *bed = get_elf_backend_data (abfd);
Elf_Internal_Shdr *symhdr = elf_elfsections (abfd) [ghdr->sh_link]; Elf_Internal_Shdr *symhdr = &elf_symtab_hdr (abfd);
if (symhdr->sh_type == SHT_SYMTAB if (ghdr->sh_info > 0
&& ghdr->sh_info > 0 && ghdr->sh_info < symhdr->sh_size / bed->s->sizeof_sym)
&& ghdr->sh_info < (symhdr->sh_size / bed->s->sizeof_sym))
return isympp[ghdr->sh_info - 1]; return isympp[ghdr->sh_info - 1];
} }
return NULL; return NULL;