FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix mi-cmd-stack.c

Browse source 
mi-cmd-stack.d had a conditional cleanup, "cleanup_tuple" that
confused the checker.  However, there was no need for this, since it
was only used via do_cleanups at the end of the function, just before
another call to do_cleanups.

So, while this is a stylistic patch for the checker, I also consider
it a generic improvement for readers of the code.

	* mi/mi-cmd-stack.c (list_arg_or_local): Remove
	"cleanup_tuple".
This commit is contained in:
Tom Tromey 2013-05-30 17:35:40 +00:00
parent 57cee33aee
commit cd82eddcf1
2 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2013-05-30 Tom Tromey <tromey@redhat.com>
* mi/mi-cmd-stack.c (list_arg_or_local): Remove
"cleanup_tuple".
2013-05-30 Tom Tromey <tromey@redhat.com> 2013-05-30 Tom Tromey <tromey@redhat.com>
* dbxread.c (dbx_read_symtab): Declare 'back_to' in a more * dbxread.c (dbx_read_symtab): Declare 'back_to' in a more

5
gdb/mi/mi-cmd-stack.c
View file

@ -397,7 +397,6 @@ list_arg_or_local (const struct frame_arg *arg, enum what_to_list what,
enum print_values values) enum print_values values)
{ {
struct cleanup *old_chain; struct cleanup *old_chain;
struct cleanup *cleanup_tuple = NULL;
struct ui_out *uiout = current_uiout; struct ui_out *uiout = current_uiout;
struct ui_file *stb; struct ui_file *stb;
@ -415,7 +414,7 @@ list_arg_or_local (const struct frame_arg *arg, enum what_to_list what,
&& (arg->val || arg->error))); && (arg->val || arg->error)));
if (values != PRINT_NO_VALUES || what == all) if (values != PRINT_NO_VALUES || what == all)
cleanup_tuple = make_cleanup_ui_out_tuple_begin_end (uiout, NULL); make_cleanup_ui_out_tuple_begin_end (uiout, NULL);
fputs_filtered (SYMBOL_PRINT_NAME (arg->sym), stb); fputs_filtered (SYMBOL_PRINT_NAME (arg->sym), stb);
if (arg->entry_kind == print_entry_values_only) if (arg->entry_kind == print_entry_values_only)
@ -458,8 +457,6 @@ list_arg_or_local (const struct frame_arg *arg, enum what_to_list what,
ui_out_field_stream (uiout, "value", stb); ui_out_field_stream (uiout, "value", stb);
} }
if (values != PRINT_NO_VALUES || what == all)
do_cleanups (cleanup_tuple);
do_cleanups (old_chain); do_cleanups (old_chain);
} }