FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move declaration of max_user_call_depth to header

Browse source 
Also removes an unnecessary declaration of cmdlist in cli-cmds.c.
I don't understand why it is there, the definition of cmdlist is
at the top of the same file.

gdb/ChangeLog:

2019-10-12  Christian Biesinger  <cbiesinger@google.com>

	* cli/cli-cmds.c (max_user_call_depth): Move comment to header.
	(show_user): Remove declaration of cmdlist.
	* cli/cli-cmds.h (max_user_call_depth): Declare.
	* cli/cli-script.c (execute_user_command): Remove declaration
	of max_user_call_depth.
This commit is contained in:
Christian Biesinger 2019-10-09 23:27:33 -05:00
parent 03d0d46a0e
commit cc8dee1f1c
4 changed files with 13 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
gdb/ChangeLog
View file

@ -1,3 +1,11 @@
2019-10-12 Christian Biesinger <cbiesinger@google.com>
* cli/cli-cmds.c (max_user_call_depth): Move comment to header.
(show_user): Remove declaration of cmdlist.
* cli/cli-cmds.h (max_user_call_depth): Declare.
* cli/cli-script.c (execute_user_command): Remove declaration
of max_user_call_depth.
2019-10-11 Jim Wilson <jimw@sifive.com> 2019-10-11 Jim Wilson <jimw@sifive.com>
* gdbsupport/print-utils.h (pulongest): Fix comment. * gdbsupport/print-utils.h (pulongest): Fix comment.

3
gdb/cli/cli-cmds.c
View file

@ -74,7 +74,7 @@ static void ambiguous_line_spec (gdb::array_view<const symtab_and_line> sals,
static void filter_sals (std::vector<symtab_and_line> &); static void filter_sals (std::vector<symtab_and_line> &);
/* Limit the call depth of user-defined commands */ /* See cli-cmds.h. */
unsigned int max_user_call_depth; unsigned int max_user_call_depth;
/* Define all cmd_list_elements. */ /* Define all cmd_list_elements. */
@ -1538,7 +1538,6 @@ static void
show_user (const char *args, int from_tty) show_user (const char *args, int from_tty)
{ {
struct cmd_list_element *c; struct cmd_list_element *c;
extern struct cmd_list_element *cmdlist;
if (args) if (args)
{ {

4
gdb/cli/cli-cmds.h
View file

@ -101,6 +101,10 @@ extern struct cmd_list_element *setchecklist;
extern struct cmd_list_element *showchecklist; extern struct cmd_list_element *showchecklist;
/* Limit the call depth of user-defined commands */
extern unsigned int max_user_call_depth;
/* Exported to gdb/top.c */ /* Exported to gdb/top.c */
void init_cmd_lists (void); void init_cmd_lists (void);

1
gdb/cli/cli-script.c
View file

@ -449,7 +449,6 @@ void
execute_user_command (struct cmd_list_element *c, const char *args) execute_user_command (struct cmd_list_element *c, const char *args)
{ {
counted_command_line cmdlines_copy; counted_command_line cmdlines_copy;
extern unsigned int max_user_call_depth;
/* Ensure that the user commands can't be deleted while they are /* Ensure that the user commands can't be deleted while they are
executing. */ executing. */