FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove two unnecessary variables from evaluate_subexp_standard

Browse source 
I noticed a couple of spots in evaluate_subexp_standard that looked
like:

    value *result;
    result = something;
    return result;

This patch simplifies these spots to a simple "return".

gdb/ChangeLog
2020-11-25  Tom Tromey  <tom@tromey.com>

	* eval.c (evaluate_subexp_standard): Remove unnecessary
	variables.
This commit is contained in:
Tom Tromey 2020-11-25 10:19:40 -07:00
parent af30c400ea
commit cbfa382abb
2 changed files with 8 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
gdb/eval.c
View file

@ -2142,12 +2142,11 @@ evaluate_subexp_standard (struct type *expect_type,
|| op == BINOP_MOD)
&& value_logical_not (arg2))
{
struct value *v_one, *retval;
struct value *v_one;
v_one = value_one (value_type (arg2));
binop_promote (exp->language_defn, exp->gdbarch, &arg1, &v_one);
retval = value_binop (arg1, v_one, op);
return retval;
return value_binop (arg1, v_one, op);
}
else
{
@ -2532,12 +2531,7 @@ evaluate_subexp_standard (struct type *expect_type,
return eval_skip_value (exp);
}
else
{
struct value *retvalp = evaluate_subexp_for_address (exp, pos,
noside);
return retvalp;
}
return evaluate_subexp_for_address (exp, pos, noside);
case UNOP_SIZEOF:
if (noside == EVAL_SKIP)