FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

PR28541, unstable cie offset in the output of readelf

Browse source 
Calculating "0 - pointer" can indeed result in seeming randomness as
the pointer address varies.

	PR 28541
	* dwarf.c (display_debug_frames): Don't print cie offset when
	invalid, print "invalid" instead.  Remove now redundant warning.
This commit is contained in:
Alan Modra 2021-11-05 21:26:16 +10:30
parent 109c1107c4
commit ca8775833b
1 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
binutils/dwarf.c
View file

@ -8777,9 +8777,6 @@ display_debug_frames (struct dwarf_section *section,
if (!cie)
{
warn ("Invalid CIE pointer 0x%s in FDE at %#08lx\n",
dwarf_vmatoa_1 (NULL, cie_id, offset_size),
(unsigned long) (saved_start - section_start));
fc->ncols = 0;
fc->col_type = (short int *) xmalloc (sizeof (short int));
fc->col_offset = (int *) xmalloc (sizeof (int));
@ -8862,12 +8859,20 @@ display_debug_frames (struct dwarf_section *section,
start += augmentation_data_len;
}
printf ("\n%08lx %s %s FDE cie=%08lx pc=",
printf ("\n%08lx %s %s FDE ",
(unsigned long)(saved_start - section_start),
dwarf_vmatoa_1 (NULL, length, fc->ptr_size),
dwarf_vmatoa_1 (NULL, cie_id, offset_size),
(unsigned long)(cie->chunk_start - section_start));
dwarf_vmatoa_1 (NULL, cie_id, offset_size));
if (cie->chunk_start)
printf ("cie=%08lx",
(unsigned long) (cie->chunk_start - section_start));
else
/* Ideally translate "invalid " to 8 chars, trailing space
is optional. */
printf (_("cie=invalid "));
printf (" pc=");
if (fc->segment_size)
printf ("%04lx:", segment_selector);