FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Free results of varobj_get_expression

Browse source 
varobj_get_expression returns an allocated string, which must be freed
by the caller.

gdb/ChangeLog:

	* mi-cmd-var.c (print_varobj): Free varobj_get_expression
	result.
	(mi_cmd_var_info_expression): Same.
	* varobj.c (varobj_get_expression): Mention in the comment that
	the result must by freed by the caller.
This commit is contained in:
Simon Marchi 2015-01-30 13:56:56 -05:00
parent afa269ae41
commit ca83fa8189
3 changed files with 21 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gdb/ChangeLog
View file

@ -1,3 +1,11 @@
2015-01-30 Simon Marchi <simon.marchi@ericsson.com>
* mi-cmd-var.c (print_varobj): Free varobj_get_expression
result.
(mi_cmd_var_info_expression): Same.
* varobj.c (varobj_get_expression): Mention in the comment that
the result must by freed by the caller.
2015-01-30 Simon Marchi <simon.marchi@ericsson.com>
* mi/mi-cmd-var.c (mi_cmd_var_info_type): Free result of

13
gdb/mi/mi-cmd-var.c
View file

@ -55,7 +55,12 @@ print_varobj (struct varobj *var, enum print_values print_values,
ui_out_field_string (uiout, "name", varobj_get_objname (var));
if (print_expression)
ui_out_field_string (uiout, "exp", varobj_get_expression (var));
{
char *exp = varobj_get_expression (var);
ui_out_field_string (uiout, "exp", exp);
xfree (exp);
}
ui_out_field_int (uiout, "numchild", varobj_get_num_children (var));
if (mi_print_value_p (var, print_values))
@ -485,6 +490,7 @@ mi_cmd_var_info_expression (char *command, char **argv, int argc)
struct ui_out *uiout = current_uiout;
const struct language_defn *lang;
struct varobj *var;
char *exp;
if (argc != 1)
error (_("-var-info-expression: Usage: NAME."));
@ -495,7 +501,10 @@ mi_cmd_var_info_expression (char *command, char **argv, int argc)
lang = varobj_get_language (var);
ui_out_field_string (uiout, "lang", lang->la_natural_name);
ui_out_field_string (uiout, "exp", varobj_get_expression (var));
exp = varobj_get_expression (var);
ui_out_field_string (uiout, "exp", exp);
xfree (exp);
}
void

3
gdb/varobj.c
View file

@ -492,7 +492,8 @@ varobj_get_objname (struct varobj *var)
return var->obj_name;
}
/* Given the handle, return the expression represented by the object. */
/* Given the handle, return the expression represented by the object. The
result must be freed by the caller. */
char *
varobj_get_expression (struct varobj *var)