FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Silence ARI warning about floatformat_to_double

Browse source 
This silences ARI at the one spot that is permitted to call
floatformat_to_double, and also removes the corresponding "fix" call
from gdb_ari.sh -- it was incorrect, and now is not needed.

gdb/ChangeLog
2019-12-13  Tom Tromey  <tromey@adacore.com>

	* contrib/ari/gdb_ari.sh: Remove "fix" call for
	floatformat_to_double.
	* target-float.c (host_float_ops<T>::from_target): Add ARI
	comment.

Change-Id: I778a17a04da417c113194004dd7de3b1df381266
This commit is contained in:
Tom Tromey 2019-12-05 08:11:31 -07:00
parent 036003a671
commit c6cbf900d4
3 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gdb/ChangeLog
View file

@ -1,3 +1,10 @@
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove "fix" call for
floatformat_to_double.
* target-float.c (host_float_ops<T>::from_target): Add ARI
comment.
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove "fix" call for abort.

1
gdb/contrib/ari/gdb_ari.sh
View file

@ -810,7 +810,6 @@ get_frame_locals_address, or get_frame_args_address."
BEGIN { doc["floatformat_to_double"] = "\
Do not use floatformat_to_double() from libierty, \
instead use floatformat_to_doublest()"
fix("floatformat_to_double", "gdb/doublest.c", 1)
category["floatformat_to_double"] = ari_regression
}
/(^|[^_[:alnum:]])floatformat_to_double[[:space:]]*\(/ {

4
gdb/target-float.c
View file

@ -647,8 +647,8 @@ host_float_ops<T>::from_target (const struct floatformat *fmt,
{
double dto;
floatformat_to_double (fmt->split_half ? fmt->split_half : fmt,
from, &dto);
floatformat_to_double /* ARI: floatformat_to_double */
(fmt->split_half ? fmt->split_half : fmt, from, &dto);
*to = (T) dto;
return;
}