FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Hurd: In the CLI, use parse_thread_id instead of global_thread_id_to_ptid

Browse source 
Follow-up to commit 14f6890677.
global_thread_id_to_ptid expects global thread numbers, which are nowadays only
used in MI, never presented to the user in the CLI.  Since this is a CLI
command, it should accept the inferior-qualified format instead.

	gdb/
	* gnu-nat.c (set_sig_thread_cmd): Use parse_thread_id instead of
	global_thread_id_to_ptid.
This commit is contained in:
Simon Marchi 2016-12-08 09:45:59 +01:00 • committed by Thomas Schwinge
parent 21389b7f34
commit c3187fa5cc
2 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gdb/ChangeLog
View file

@ -1,3 +1,9 @@
2016-12-08 Simon Marchi <simon.marchi@ericsson.com>
Thomas Schwinge <thomas@codesourcery.com>
* gnu-nat.c (set_sig_thread_cmd): Use parse_thread_id instead of
global_thread_id_to_ptid.
2016-12-08 Thomas Schwinge <thomas@codesourcery.com>
* config/i386/i386gnu.mh (%_S.o %_U.o): Add "-x c" to

12
gdb/gnu-nat.c
View file

@ -63,6 +63,7 @@ extern "C"
#include "gdbcore.h"
#include "gdbthread.h"
#include "gdb_obstack.h"
#include "tid-parse.h"
#include "gnu-nat.h"
#include "inf-child.h"
@ -2975,19 +2976,14 @@ set_sig_thread_cmd (char *args, int from_tty)
if (!args || (!isdigit (*args) && strcmp (args, "none") != 0))
error (_("Illegal argument to \"set signal-thread\" command.\n"
"Should be an integer thread ID, or `none'."));
"Should be a thread ID, or \"none\"."));
if (strcmp (args, "none") == 0)
inf->signal_thread = 0;
else
{
ptid_t ptid = global_thread_id_to_ptid (atoi (args));
if (ptid_equal (ptid, minus_one_ptid))
error (_("Thread ID %s not known. "
"Use the \"info threads\" command to\n"
"see the IDs of currently known threads."), args);
inf->signal_thread = inf_tid_to_thread (inf, ptid_get_lwp (ptid));
struct thread_info *tp = parse_thread_id (args, NULL);
inf->signal_thread = inf_tid_to_thread (inf, ptid_get_lwp (tp->ptid));
}
}