FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove the "listhead" argument from finish_block

Browse source 
finish_block is only ever called with "&local_symbols" as the
"listhead" argument.  So, remove this argument.

gdb/ChangeLog
2018-07-20  Tom Tromey  <tom@tromey.com>

	* xcoffread.c (read_xcoff_symtab): Update.
	* dwarf2read.c (read_func_scope, read_lexical_block_scope):
	Update.
	* dbxread.c (process_one_symbol): Update.
	* coffread.c (coff_symtab_read): Update.
	* buildsym.h (finish_block): Update.
	* buildsym.c (finish_block): Remove "listhead" argument.
	(end_symtab_get_static_block): Update.
This commit is contained in:
Tom Tromey 2018-05-21 00:41:21 -06:00
parent 5ac045503d
commit c233e9c641
7 changed files with 22 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

11
gdb/ChangeLog
View file

@ -1,3 +1,14 @@
2018-07-20 Tom Tromey <tom@tromey.com>
* xcoffread.c (read_xcoff_symtab): Update.
* dwarf2read.c (read_func_scope, read_lexical_block_scope):
Update.
* dbxread.c (process_one_symbol): Update.
* coffread.c (coff_symtab_read): Update.
* buildsym.h (finish_block): Update.
* buildsym.c (finish_block): Remove "listhead" argument.
(end_symtab_get_static_block): Update.
2018-07-20 Tom Tromey <tom@tromey.com> 2018-07-20 Tom Tromey <tom@tromey.com>
* buildsym.h (class scoped_free_pendings): Remove constructor. * buildsym.h (class scoped_free_pendings): Remove constructor.

5
gdb/buildsym.c
View file

@ -576,12 +576,11 @@ finish_block_internal (struct symbol *symbol,
struct block * struct block *
finish_block (struct symbol *symbol, finish_block (struct symbol *symbol,
struct pending **listhead,
struct pending_block *old_blocks, struct pending_block *old_blocks,
const struct dynamic_prop *static_link, const struct dynamic_prop *static_link,
CORE_ADDR start, CORE_ADDR end) CORE_ADDR start, CORE_ADDR end)
{ {
return finish_block_internal (symbol, listhead, old_blocks, static_link, return finish_block_internal (symbol, &local_symbols, old_blocks, static_link,
start, end, 0, 0); start, end, 0, 0);
} }
@ -1196,7 +1195,7 @@ end_symtab_get_static_block (CORE_ADDR end_addr, int expandable, int required)
struct context_stack cstk = pop_context (); struct context_stack cstk = pop_context ();
/* Make a block for the local symbols within. */ /* Make a block for the local symbols within. */
finish_block (cstk.name, &local_symbols, cstk.old_blocks, NULL, finish_block (cstk.name, cstk.old_blocks, NULL,
cstk.start_addr, end_addr); cstk.start_addr, end_addr);
if (!buildsym_compunit->m_context_stack.empty ()) if (!buildsym_compunit->m_context_stack.empty ())

1
gdb/buildsym.h
View file

@ -144,7 +144,6 @@ extern struct symbol *find_symbol_in_list (struct pending *list,
char *name, int length); char *name, int length);
extern struct block *finish_block (struct symbol *symbol, extern struct block *finish_block (struct symbol *symbol,
struct pending **listhead,
struct pending_block *old_blocks, struct pending_block *old_blocks,
const struct dynamic_prop *static_link, const struct dynamic_prop *static_link,
CORE_ADDR start, CORE_ADDR start,

4
gdb/coffread.c
View file

@ -1135,7 +1135,7 @@ coff_symtab_read (minimal_symbol_reader &reader,
enter_linenos (fcn_line_ptr, fcn_first_line, enter_linenos (fcn_line_ptr, fcn_first_line,
fcn_last_line, objfile); fcn_last_line, objfile);
finish_block (cstk.name, &local_symbols, cstk.old_blocks, finish_block (cstk.name, cstk.old_blocks,
NULL, cstk.start_addr, NULL, cstk.start_addr,
fcn_cs_saved.c_value fcn_cs_saved.c_value
+ fcn_aux_saved.x_sym.x_misc.x_fsize + fcn_aux_saved.x_sym.x_misc.x_fsize
@ -1177,7 +1177,7 @@ coff_symtab_read (minimal_symbol_reader &reader,
cs->c_value + ANOFFSET (objfile->section_offsets, cs->c_value + ANOFFSET (objfile->section_offsets,
SECT_OFF_TEXT (objfile)); SECT_OFF_TEXT (objfile));
/* Make a block for the local symbols within. */ /* Make a block for the local symbols within. */
finish_block (0, &local_symbols, cstk.old_blocks, NULL, finish_block (0, cstk.old_blocks, NULL,
cstk.start_addr, tmpaddr); cstk.start_addr, tmpaddr);
} }
/* Now pop locals of block just finished. */ /* Now pop locals of block just finished. */

6
gdb/dbxread.c
View file

@ -2516,7 +2516,7 @@ process_one_symbol (int type, int desc, CORE_ADDR valu, const char *name,
cstk = pop_context (); cstk = pop_context ();
/* Make a block for the local symbols within. */ /* Make a block for the local symbols within. */
block = finish_block (cstk.name, &local_symbols, block = finish_block (cstk.name,
cstk.old_blocks, NULL, cstk.old_blocks, NULL,
cstk.start_addr, cstk.start_addr + valu); cstk.start_addr, cstk.start_addr + valu);
@ -2603,7 +2603,7 @@ process_one_symbol (int type, int desc, CORE_ADDR valu, const char *name,
cstk.start_addr = valu; cstk.start_addr = valu;
} }
/* Make a block for the local symbols within. */ /* Make a block for the local symbols within. */
finish_block (0, &local_symbols, cstk.old_blocks, NULL, finish_block (0, cstk.old_blocks, NULL,
cstk.start_addr, valu); cstk.start_addr, valu);
} }
} }
@ -2890,7 +2890,7 @@ process_one_symbol (int type, int desc, CORE_ADDR valu, const char *name,
cstk = pop_context (); cstk = pop_context ();
/* Make a block for the local symbols within. */ /* Make a block for the local symbols within. */
block = finish_block (cstk.name, &local_symbols, block = finish_block (cstk.name,
cstk.old_blocks, NULL, cstk.old_blocks, NULL,
cstk.start_addr, valu); cstk.start_addr, valu);

4
gdb/dwarf2read.c
View file

@ -13685,7 +13685,7 @@ read_func_scope (struct die_info *die, struct dwarf2_cu *cu)
struct context_stack cstk = pop_context (); struct context_stack cstk = pop_context ();
/* Make a block for the local symbols within. */ /* Make a block for the local symbols within. */
block = finish_block (cstk.name, &local_symbols, cstk.old_blocks, block = finish_block (cstk.name, cstk.old_blocks,
cstk.static_link, lowpc, highpc); cstk.static_link, lowpc, highpc);
/* For C++, set the block's scope. */ /* For C++, set the block's scope. */
@ -13781,7 +13781,7 @@ read_lexical_block_scope (struct die_info *die, struct dwarf2_cu *cu)
if (local_symbols != NULL || (*get_local_using_directives ()) != NULL) if (local_symbols != NULL || (*get_local_using_directives ()) != NULL)
{ {
struct block *block struct block *block
= finish_block (0, &local_symbols, cstk.old_blocks, NULL, = finish_block (0, cstk.old_blocks, NULL,
cstk.start_addr, highpc); cstk.start_addr, highpc);
/* Note that recording ranges after traversing children, as we /* Note that recording ranges after traversing children, as we

4
gdb/xcoffread.c
View file

@ -1408,7 +1408,7 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
break; break;
} }
finish_block (cstk.name, &local_symbols, cstk.old_blocks, finish_block (cstk.name, cstk.old_blocks,
NULL, cstk.start_addr, NULL, cstk.start_addr,
(fcn_cs_saved.c_value (fcn_cs_saved.c_value
+ fcn_aux_saved.x_sym.x_misc.x_fsize + fcn_aux_saved.x_sym.x_misc.x_fsize
@ -1499,7 +1499,7 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
if (local_symbols && !outermost_context_p ()) if (local_symbols && !outermost_context_p ())
{ {
/* Make a block for the local symbols within. */ /* Make a block for the local symbols within. */
finish_block (cstk.name, &local_symbols, finish_block (cstk.name,
cstk.old_blocks, NULL, cstk.old_blocks, NULL,
cstk.start_addr, cstk.start_addr,
(cs->c_value (cs->c_value