FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdbserver: Move remote_debug to a single place

Browse source 
A comment in debug.h (written in 2014) states: "We declare debug format
variables here, and debug_threads but no other debug content variables
(e.g., not remote_debug) because while this file is not currently used by
IPA it may be some day, and IPA may have its own set of debug content
variables".

This has resulted in remote_debug being declared in many .c/.h files
throughout gdbserver.

It would be much simplier to define it one place.  The most logical place to
define it is in debug.h, surrounded by #define guards.  If IPA is changed,
then at that point the variable can be moved elsewhere.

gdb/gdbserver/ChangeLog:

	* debug.c (remote_debug): Add definition.
	* debug.h (remote_debug): Add declaration.
	* hostio.c (remote_debug): Remove declaration.
	* remote-utils.c (struct ui_file): Likewise.
	(remote_debug): Likewise.
	* remote-utils.h (remote_debug): Likewise,
	* server.c (remote_debug): Remove definition.
This commit is contained in:
Alan Hayward 2019-04-12 14:21:55 +01:00
parent 1cfe2726f1
commit c1bc0935a4
7 changed files with 18 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

10
gdb/gdbserver/ChangeLog
View file

@ -1,3 +1,13 @@
2019-04-17 Alan Hayward <alan.hayward@arm.com>
* debug.c (remote_debug): Add definition.
* debug.h (remote_debug): Add declaration.
* hostio.c (remote_debug): Remove declaration.
* remote-utils.c (struct ui_file): Likewise.
(remote_debug): Likewise.
* remote-utils.h (remote_debug): Likewise,
* server.c (remote_debug): Remove definition.
2019-04-10 Kevin Buettner <kevinb@redhat.com>
* linux-x86-low.c (x86_fill_gregset): Sign extend EAX value

4
gdb/gdbserver/debug.c
View file

@ -19,6 +19,10 @@
#include "server.h"
#include <chrono>
#if !defined (IN_PROCESS_AGENT)
int remote_debug = 0;
#endif
/* Enable miscellaneous debugging output. The name is historical - it
was originally used to debug LinuxThreads support. */
int debug_threads;

11
gdb/gdbserver/debug.h
View file

@ -19,13 +19,10 @@
#ifndef GDBSERVER_DEBUG_H
#define GDBSERVER_DEBUG_H
/* We declare debug format variables here, and debug_threads but no other
debug content variables (e.g., not remote_debug) because while this file
is not currently used by IPA it may be some day, and IPA may have its own
set of debug content variables. It's ok to declare debug_threads here
because it is misnamed - a better name is debug_basic or some such,
which can work for any program, gdbserver or IPA. If/when this file is
used with IPA it is recommended to fix debug_thread's name. */
#if !defined (IN_PROCESS_AGENT)
extern int remote_debug;
#endif
extern int debug_threads;
extern int debug_timestamp;

2
gdb/gdbserver/hostio.c
View file

@ -29,8 +29,6 @@
#include <sys/stat.h>
#include "common/fileio.h"
extern int remote_debug;
struct fd_list
{
int fd;

3
gdb/gdbserver/remote-utils.c
View file

@ -108,9 +108,6 @@ struct sym_cache
struct sym_cache *next;
};
int remote_debug = 0;
struct ui_file *gdb_stdlog;
static int remote_is_stdio = 0;
static gdb_fildes_t remote_desc = INVALID_DESCRIPTOR;

2
gdb/gdbserver/remote-utils.h
View file

@ -19,8 +19,6 @@
#ifndef GDBSERVER_REMOTE_UTILS_H
#define GDBSERVER_REMOTE_UTILS_H
extern int remote_debug;
int gdb_connected (void);
#define STDIO_CONNECTION_NAME "stdio"

2
gdb/gdbserver/server.c
View file

@ -328,8 +328,6 @@ attach_inferior (int pid)
return 0;
}
extern int remote_debug;
/* Decode a qXfer read request. Return 0 if everything looks OK,
or -1 otherwise. */