FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb/

Browse source 
Report error on inaccessible memory.
	* cli/cli-dump.c: Include gdbcore.h.
	(dump_memory_to_file): Call read_memory instead of target_read_memory.

gdb/testsuite/
	* gdb.base/dump.exp (inaccessible memory is reported): New test.
This commit is contained in:
Jan Kratochvil 2009-07-09 20:30:59 +00:00
parent e0452928e8
commit c0ac0ec78d
4 changed files with 17 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
gdb/ChangeLog
View file

@ -1,3 +1,9 @@
2009-07-09 Jan Kratochvil <jan.kratochvil@redhat.com>
Report error on inaccessible memory.
* cli/cli-dump.c: Include gdbcore.h.
(dump_memory_to_file): Call read_memory instead of target_read_memory.
2009-07-09 Hui Zhu <teawater@gmail.com> 2009-07-09 Hui Zhu <teawater@gmail.com>
* solib.c (solib_bfd_open): Output a warning if solib's * solib.c (solib_bfd_open): Output a warning if solib's
@ -60,7 +66,7 @@
Fix hang in floating varobjs. Fix hang in floating varobjs.
* varob.c (varobj_invalidate): Advance to next * varobj.c (varobj_invalidate): Advance to next
element when processing floating varobj. element when processing floating varobj.
2009-07-07 Vladimir Prus <vladimir@codesourcery.com> 2009-07-07 Vladimir Prus <vladimir@codesourcery.com>

3
gdb/cli/cli-dump.c
View file

@ -30,6 +30,7 @@
#include <ctype.h> #include <ctype.h>
#include "target.h" #include "target.h"
#include "readline/readline.h" #include "readline/readline.h"
#include "gdbcore.h"
#define XMALLOC(TYPE) ((TYPE*) xmalloc (sizeof (TYPE))) #define XMALLOC(TYPE) ((TYPE*) xmalloc (sizeof (TYPE)))
@ -246,7 +247,7 @@ dump_memory_to_file (char *cmd, char *mode, char *file_format)
value. */ value. */
buf = xmalloc (count); buf = xmalloc (count);
make_cleanup (xfree, buf); make_cleanup (xfree, buf);
target_read_memory (lo, buf, count); read_memory (lo, buf, count);
/* Have everything. Open/write the data. */ /* Have everything. Open/write the data. */
if (file_format == NULL || strcmp (file_format, "binary") == 0) if (file_format == NULL || strcmp (file_format, "binary") == 0)

4
gdb/testsuite/ChangeLog
View file

@ -1,3 +1,7 @@
2009-07-09 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.base/dump.exp (inaccessible memory is reported): New test.
2009-07-07 Tom Tromey <tromey@redhat.com> 2009-07-07 Tom Tromey <tromey@redhat.com>
* gdb.base/call-rt-st.exp: Update for change to escape output. * gdb.base/call-rt-st.exp: Update for change to escape output.

4
gdb/testsuite/gdb.base/dump.exp
View file

@ -58,6 +58,10 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable ${op
gdb_exit gdb_exit
gdb_start gdb_start
gdb_reinitialize_dir $srcdir/$subdir gdb_reinitialize_dir $srcdir/$subdir
gdb_test "dump mem /dev/null 0x10 0x20" "Cannot access memory at address 0x10" \
"inaccessible memory is reported"
gdb_load ${binfile} gdb_load ${binfile}
# Clean up any stale output files from previous test runs # Clean up any stale output files from previous test runs