FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

sim: model: constify sim_machs storage

Browse source 
The array of pointers is never modified, so mark it const so it ends
up in the read-only data section.
This commit is contained in:
Mike Frysinger 2021-06-27 01:26:30 -04:00
parent aa2e84dee6
commit ba9666525f
21 changed files with 60 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

4
sim/bfin/ChangeLog
View file

@ -1,3 +1,7 @@
2021-06-29 Mike Frysinger <vapier@gentoo.org>
* machs.c (sim_machs): Mark const.
2021-06-27 Mike Frysinger <vapier@gentoo.org> 2021-06-27 Mike Frysinger <vapier@gentoo.org>
* Makefile.in: Change to $(SDL_CFLAGS) & $(SDL_LIBS). * Makefile.in: Change to $(SDL_CFLAGS) & $(SDL_LIBS).

2
sim/bfin/machs.c
View file

@ -1962,7 +1962,7 @@ static const SIM_MACH bfin_mach =
bfin_prepare_run bfin_prepare_run
}; };
const SIM_MACH *sim_machs[] = const SIM_MACH * const sim_machs[] =
{ {
& bfin_mach, & bfin_mach,
NULL NULL

4
sim/bpf/ChangeLog
View file

@ -1,3 +1,7 @@
2021-06-29 Mike Frysinger <vapier@gentoo.org>
* arch.c (sim_machs): Mark const.
2021-06-28 Mike Frysinger <vapier@gentoo.org> 2021-06-28 Mike Frysinger <vapier@gentoo.org>
* Makefile.in (SIM_WERROR_CFLAGS): Delete. * Makefile.in (SIM_WERROR_CFLAGS): Delete.

2
sim/bpf/arch.c
View file

@ -25,7 +25,7 @@ This file is part of the GNU simulators.
#include "sim-main.h" #include "sim-main.h"
#include "bfd.h" #include "bfd.h"
const SIM_MACH *sim_machs[] = const SIM_MACH * const sim_machs[] =
{ {
#ifdef HAVE_CPU_BPFBF #ifdef HAVE_CPU_BPFBF
& bpf_mach, & bpf_mach,

9
sim/common/ChangeLog
View file

@ -1,3 +1,12 @@
2021-06-29 Mike Frysinger <vapier@gentoo.org>
* sim-model.c (model_option_handler): Make machp const.
(sim_model_lookup): Likewise.
(sim_mach_lookup): Likewise.
(sim_mach_lookup_bfd_name): Likewise.
(sim_machs): Add const.
* sim-model.h (sim_machs): Likewise.
2021-06-29 Mike Frysinger <vapier@gentoo.org> 2021-06-29 Mike Frysinger <vapier@gentoo.org>
* sim-io.h (sim_io_vprintf): Add ATTRIBUTE_PRINTF. * sim-io.h (sim_io_vprintf): Add ATTRIBUTE_PRINTF.

10
sim/common/sim-model.c
View file

@ -74,7 +74,7 @@ model_option_handler (SIM_DESC sd, sim_cpu *cpu, int opt,
case OPTION_MODEL_INFO : case OPTION_MODEL_INFO :
{ {
const SIM_MACH **machp; const SIM_MACH * const *machp;
const SIM_MODEL *model; const SIM_MODEL *model;
for (machp = & sim_machs[0]; *machp != NULL; ++machp) for (machp = & sim_machs[0]; *machp != NULL; ++machp)
{ {
@ -140,7 +140,7 @@ sim_model_set (SIM_DESC sd, sim_cpu *cpu, const SIM_MODEL *model)
const SIM_MODEL * const SIM_MODEL *
sim_model_lookup (const char *name) sim_model_lookup (const char *name)
{ {
const SIM_MACH **machp; const SIM_MACH * const *machp;
const SIM_MODEL *model; const SIM_MODEL *model;
for (machp = & sim_machs[0]; *machp != NULL; ++machp) for (machp = & sim_machs[0]; *machp != NULL; ++machp)
@ -160,7 +160,7 @@ sim_model_lookup (const char *name)
const SIM_MACH * const SIM_MACH *
sim_mach_lookup (const char *name) sim_mach_lookup (const char *name)
{ {
const SIM_MACH **machp; const SIM_MACH * const *machp;
for (machp = & sim_machs[0]; *machp != NULL; ++machp) for (machp = & sim_machs[0]; *machp != NULL; ++machp)
{ {
@ -176,7 +176,7 @@ sim_mach_lookup (const char *name)
const SIM_MACH * const SIM_MACH *
sim_mach_lookup_bfd_name (const char *name) sim_mach_lookup_bfd_name (const char *name)
{ {
const SIM_MACH **machp; const SIM_MACH * const *machp;
for (machp = & sim_machs[0]; *machp != NULL; ++machp) for (machp = & sim_machs[0]; *machp != NULL; ++machp)
{ {
@ -251,7 +251,7 @@ sim_model_init (SIM_DESC sd)
#if !WITH_MODEL_P #if !WITH_MODEL_P
/* Set up basic model support. This is a stub for ports that do not define /* Set up basic model support. This is a stub for ports that do not define
models. See sim-model.h for more details. */ models. See sim-model.h for more details. */
const SIM_MACH *sim_machs[] = const SIM_MACH * const sim_machs[] =
{ {
NULL NULL
}; };

2
sim/common/sim-model.h
View file

@ -140,7 +140,7 @@ typedef struct model {
/* ??? In a simulator of multiple architectures, will need multiple copies of /* ??? In a simulator of multiple architectures, will need multiple copies of
this. Have an `archs' array that contains a pointer to the machs array this. Have an `archs' array that contains a pointer to the machs array
for each (which in turn has a pointer to the models array for each). */ for each (which in turn has a pointer to the models array for each). */
extern const SIM_MACH *sim_machs[]; extern const SIM_MACH * const sim_machs[];
/* Model module handlers. */ /* Model module handlers. */
extern MODULE_INSTALL_FN sim_model_install; extern MODULE_INSTALL_FN sim_model_install;

4
sim/cris/ChangeLog
View file

@ -1,3 +1,7 @@
2021-06-29 Mike Frysinger <vapier@gentoo.org>
* arch.c (sim_machs): Mark const.
2021-06-28 Mike Frysinger <vapier@gentoo.org> 2021-06-28 Mike Frysinger <vapier@gentoo.org>
* cpuv10.c (crisv10f_record_trace_results): Delete function. * cpuv10.c (crisv10f_record_trace_results): Delete function.

2
sim/cris/arch.c
View file

@ -24,7 +24,7 @@ This file is part of the GNU simulators.
#include "sim-main.h" #include "sim-main.h"
#include "bfd.h" #include "bfd.h"
const SIM_MACH *sim_machs[] = const SIM_MACH * const sim_machs[] =
{ {
#ifdef HAVE_CPU_CRISV10F #ifdef HAVE_CPU_CRISV10F
& crisv10_mach, & crisv10_mach,

4
sim/frv/ChangeLog
View file

@ -1,3 +1,7 @@
2021-06-29 Mike Frysinger <vapier@gentoo.org>
* arch.c (sim_machs): Mark const.
2021-06-28 Mike Frysinger <vapier@gentoo.org> 2021-06-28 Mike Frysinger <vapier@gentoo.org>
* cpu.c (frvbf_record_trace_results): Delete function. * cpu.c (frvbf_record_trace_results): Delete function.

2
sim/frv/arch.c
View file

@ -24,7 +24,7 @@ This file is part of the GNU simulators.
#include "sim-main.h" #include "sim-main.h"
#include "bfd.h" #include "bfd.h"
const SIM_MACH *sim_machs[] = const SIM_MACH * const sim_machs[] =
{ {
#ifdef HAVE_CPU_FRVBF #ifdef HAVE_CPU_FRVBF
& frv_mach, & frv_mach,

4
sim/iq2000/ChangeLog
View file

@ -1,3 +1,7 @@
2021-06-29 Mike Frysinger <vapier@gentoo.org>
* arch.c (sim_machs): Mark const.
2021-06-28 Mike Frysinger <vapier@gentoo.org> 2021-06-28 Mike Frysinger <vapier@gentoo.org>
* cpu.c (iq2000bf_record_trace_results): Delete function. * cpu.c (iq2000bf_record_trace_results): Delete function.

2
sim/iq2000/arch.c
View file

@ -24,7 +24,7 @@ This file is part of the GNU simulators.
#include "sim-main.h" #include "sim-main.h"
#include "bfd.h" #include "bfd.h"
const SIM_MACH *sim_machs[] = const SIM_MACH * const sim_machs[] =
{ {
#ifdef HAVE_CPU_IQ2000BF #ifdef HAVE_CPU_IQ2000BF
& iq2000_mach, & iq2000_mach,

4
sim/lm32/ChangeLog
View file

@ -1,3 +1,7 @@
2021-06-29 Mike Frysinger <vapier@gentoo.org>
* arch.c (sim_machs): Mark const.
2021-06-28 Mike Frysinger <vapier@gentoo.org> 2021-06-28 Mike Frysinger <vapier@gentoo.org>
* cpu.c (lm32bf_record_trace_results): Delete function. * cpu.c (lm32bf_record_trace_results): Delete function.

2
sim/lm32/arch.c
View file

@ -24,7 +24,7 @@ This file is part of the GNU simulators.
#include "sim-main.h" #include "sim-main.h"
#include "bfd.h" #include "bfd.h"
const SIM_MACH *sim_machs[] = const SIM_MACH * const sim_machs[] =
{ {
#ifdef HAVE_CPU_LM32BF #ifdef HAVE_CPU_LM32BF
& lm32_mach, & lm32_mach,

4
sim/m32r/ChangeLog
View file

@ -1,3 +1,7 @@
2021-06-29 Mike Frysinger <vapier@gentoo.org>
* arch.c (sim_machs): Mark const.
2021-06-28 Mike Frysinger <vapier@gentoo.org> 2021-06-28 Mike Frysinger <vapier@gentoo.org>
* cpu.c (m32rbf_record_trace_results): Delete function. * cpu.c (m32rbf_record_trace_results): Delete function.

2
sim/m32r/arch.c
View file

@ -24,7 +24,7 @@ This file is part of the GNU simulators.
#include "sim-main.h" #include "sim-main.h"
#include "bfd.h" #include "bfd.h"
const SIM_MACH *sim_machs[] = const SIM_MACH * const sim_machs[] =
{ {
#ifdef HAVE_CPU_M32RBF #ifdef HAVE_CPU_M32RBF
& m32r_mach, & m32r_mach,

4
sim/or1k/ChangeLog
View file

@ -1,3 +1,7 @@
2021-06-29 Mike Frysinger <vapier@gentoo.org>
* arch.c (sim_machs): Mark const.
2021-06-28 Mike Frysinger <vapier@gentoo.org> 2021-06-28 Mike Frysinger <vapier@gentoo.org>
* cpu.c (or1k32bf_record_trace_results): Delete function. * cpu.c (or1k32bf_record_trace_results): Delete function.

2
sim/or1k/arch.c
View file

@ -25,7 +25,7 @@ This file is part of the GNU simulators.
#include "sim-main.h" #include "sim-main.h"
#include "bfd.h" #include "bfd.h"
const SIM_MACH *sim_machs[] = const SIM_MACH * const sim_machs[] =
{ {
#ifdef HAVE_CPU_OR1K32BF #ifdef HAVE_CPU_OR1K32BF
& or32_mach, & or32_mach,

4
sim/riscv/ChangeLog
View file

@ -1,3 +1,7 @@
2021-06-29 Mike Frysinger <vapier@gentoo.org>
* machs.c (sim_machs): Mark const.
2021-06-22 Mike Frysinger <vapier@gentoo.org> 2021-06-22 Mike Frysinger <vapier@gentoo.org>
* configure: Regenerate. * configure: Regenerate.

2
sim/riscv/machs.c
View file

@ -111,7 +111,7 @@ static const SIM_MACH rv128i_mach =
#endif #endif
/* Order matters here. */ /* Order matters here. */
const SIM_MACH *sim_machs[] = const SIM_MACH * const sim_machs[] =
{ {
#if WITH_TARGET_WORD_BITSIZE >= 128 #if WITH_TARGET_WORD_BITSIZE >= 128
&rv128i_mach, &rv128i_mach,