Rename to allow_xml_test

This changes gdb_skip_xml_test to invert the sense, and renames it to
allow_xml_test.
This commit is contained in:
Tom Tromey 2023-01-07 11:48:45 -07:00
parent 79749205e7
commit b963a97fb1
20 changed files with 24 additions and 25 deletions

View file

@ -13,7 +13,7 @@
# You should have received a copy of the GNU General Public License # You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>. # along with this program. If not, see <http://www.gnu.org/licenses/>.
require !gdb_skip_xml_test require allow_xml_test
gdb_start gdb_start

View file

@ -781,7 +781,7 @@ fill_all_syscalls_numbers
# Execute the tests, using XML support # Execute the tests, using XML support
gdb_exit gdb_exit
if { ![gdb_skip_xml_test] } { if { [allow_xml_test] } {
clean_restart $binfile clean_restart $binfile
do_syscall_tests do_syscall_tests

View file

@ -22,7 +22,7 @@ if {![istarget *-*-linux*]} {
} }
# Support for XML-output is needed to run this test. # Support for XML-output is needed to run this test.
require !gdb_skip_xml_test require allow_xml_test
# Compile test program. # Compile test program.
if { [prepare_for_testing "failed to prepare" $testfile $srcfile {debug pthreads}] } { if { [prepare_for_testing "failed to prepare" $testfile $srcfile {debug pthreads}] } {

View file

@ -14,7 +14,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>. # along with this program. If not, see <http://www.gnu.org/licenses/>.
# Valgrind gdbserver requires gdb with xml support. # Valgrind gdbserver requires gdb with xml support.
require !gdb_skip_xml_test require allow_xml_test
load_lib valgrind.exp load_lib valgrind.exp

View file

@ -19,7 +19,7 @@
# automatically instead of getting stuck or crashing. # automatically instead of getting stuck or crashing.
# Valgrind gdbserver requires gdb with xml support. # Valgrind gdbserver requires gdb with xml support.
require !gdb_skip_xml_test require allow_xml_test
load_lib valgrind.exp load_lib valgrind.exp

View file

@ -30,7 +30,7 @@
# Aborted (core dumped) # Aborted (core dumped)
# Valgrind gdbserver requires gdb with xml support. # Valgrind gdbserver requires gdb with xml support.
require !gdb_skip_xml_test require allow_xml_test
load_lib valgrind.exp load_lib valgrind.exp

View file

@ -14,7 +14,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>. # along with this program. If not, see <http://www.gnu.org/licenses/>.
# Valgrind gdbserver requires gdb with xml support. # Valgrind gdbserver requires gdb with xml support.
require !gdb_skip_xml_test require allow_xml_test
load_lib valgrind.exp load_lib valgrind.exp

View file

@ -19,7 +19,7 @@ require !gdb_debug_enabled
load_lib completion-support.exp load_lib completion-support.exp
set do_xml_test [expr ![gdb_skip_xml_test]] set do_xml_test [allow_xml_test]
standard_testfile standard_testfile

View file

@ -21,7 +21,7 @@ set MIFLAGS "-i=mi"
standard_testfile standard_testfile
# Support for XML is needed to run this test. # Support for XML is needed to run this test.
require !gdb_skip_xml_test require allow_xml_test
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } { if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
untested "failed to compile" untested "failed to compile"

View file

@ -23,7 +23,7 @@ if {![istarget *-*-linux*]} {
} }
# Support for XML-output is needed to run this test. # Support for XML-output is needed to run this test.
require !gdb_skip_xml_test require allow_xml_test
gdb_exit gdb_exit
if [mi_gdb_start] { if [mi_gdb_start] {

View file

@ -27,8 +27,8 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
return -1 return -1
} }
# gdb_skip_xml_test must be called while gdb is not running. # allow_xml_test must be called while gdb is not running.
set do_xml_test [expr ![gdb_skip_xml_test]] set do_xml_test [allow_xml_test]
save_vars { GDBFLAGS } { save_vars { GDBFLAGS } {
# If GDB and GDBserver are both running locally, set the sysroot to avoid # If GDB and GDBserver are both running locally, set the sysroot to avoid

View file

@ -37,7 +37,7 @@
# #
# 4. Indentation of lines will be preserved so your input file needs # 4. Indentation of lines will be preserved so your input file needs
# to follow the expected indentation. # to follow the expected indentation.
require !gdb_skip_xml_test require allow_xml_test
gdb_start gdb_start

View file

@ -17,7 +17,7 @@
# You should have received a copy of the GNU General Public License # You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>. # along with this program. If not, see <http://www.gnu.org/licenses/>.
require !gdb_skip_xml_test require allow_xml_test
gdb_start gdb_start

View file

@ -13,7 +13,7 @@
# You should have received a copy of the GNU General Public License # You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>. # along with this program. If not, see <http://www.gnu.org/licenses/>.
require !gdb_skip_xml_test require allow_xml_test
gdb_start gdb_start

View file

@ -13,7 +13,7 @@
# You should have received a copy of the GNU General Public License # You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>. # along with this program. If not, see <http://www.gnu.org/licenses/>.
require !gdb_skip_xml_test require allow_xml_test
gdb_start gdb_start

View file

@ -13,7 +13,7 @@
# You should have received a copy of the GNU General Public License # You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>. # along with this program. If not, see <http://www.gnu.org/licenses/>.
require !gdb_skip_xml_test require allow_xml_test
gdb_start gdb_start

View file

@ -16,7 +16,7 @@
# Testing for 'maint print xml-tdesc'. Check we can print out the # Testing for 'maint print xml-tdesc'. Check we can print out the
# current target description and load it back in again. # current target description and load it back in again.
require !gdb_skip_xml_test require allow_xml_test
standard_testfile standard_testfile

View file

@ -13,7 +13,7 @@
# You should have received a copy of the GNU General Public License # You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>. # along with this program. If not, see <http://www.gnu.org/licenses/>.
require !gdb_skip_xml_test require allow_xml_test
gdb_start gdb_start

View file

@ -6970,17 +6970,16 @@ proc gdb_skip_bogus_test { msg } {
return 0 return 0
} }
# Return true if a test should be skipped due to lack of XML support # Return true if XML support is enabled in the host GDB.
# in the host GDB.
# NOTE: This must be called while gdb is *not* running. # NOTE: This must be called while gdb is *not* running.
gdb_caching_proc gdb_skip_xml_test { gdb_caching_proc allow_xml_test {
global gdb_spawn_id global gdb_spawn_id
global gdb_prompt global gdb_prompt
global srcdir global srcdir
if { [info exists gdb_spawn_id] } { if { [info exists gdb_spawn_id] } {
error "GDB must not be running in gdb_skip_xml_tests." error "GDB must not be running in allow_xml_tests."
} }
set xml_file [gdb_remote_download host "${srcdir}/gdb.xml/trivial.xml"] set xml_file [gdb_remote_download host "${srcdir}/gdb.xml/trivial.xml"]
@ -6994,7 +6993,7 @@ gdb_caching_proc gdb_skip_xml_test {
-re ".*$gdb_prompt $" { } -re ".*$gdb_prompt $" { }
} }
gdb_exit gdb_exit
return $xml_missing return [expr {!$xml_missing}]
} }
# Return true if argv[0] is available. # Return true if argv[0] is available.

View file

@ -171,7 +171,7 @@ proc skip_gdbserver_tests { } {
# multiple target descriptions, GDB doesn't know which target # multiple target descriptions, GDB doesn't know which target
# description GDBserver uses, and may fail to parse 'g' packet # description GDBserver uses, and may fail to parse 'g' packet
# after connection. # after connection.
if { [gdb_skip_xml_test] if { ![allow_xml_test]
&& ([istarget "arm*-*-linux*"] && ([istarget "arm*-*-linux*"]
|| [istarget "aarch64*-*-linux*"] || [istarget "aarch64*-*-linux*"]
|| [istarget "mips*-*-linux*"] || [istarget "mips*-*-linux*"]