libctf, types: ensure the emission of ECTF_NOPARENT

ctf_variable_iter was returning a (positive!) error code rather than
setting the error in the passed-in ctf_file_t.

Reviewed-by: Nick Alcock <nick.alcock@oracle.com>

libctf/
	* ctf-types.c (ctf_variable_iter): Fix error return.
This commit is contained in:
Egeyar Bagcioglu 2020-06-03 17:36:51 +01:00 committed by Nick Alcock
parent ec388c16cd
commit b7190c821e
2 changed files with 5 additions and 1 deletions

View file

@ -1,3 +1,7 @@
2020-07-22 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
* ctf-types.c (ctf_variable_iter): Fix error return.
2020-07-22 Nick Alcock <nick.alcock@oracle.com>
* ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.

View file

@ -495,7 +495,7 @@ ctf_variable_iter (ctf_file_t *fp, ctf_variable_f *func, void *arg)
int rc;
if ((fp->ctf_flags & LCTF_CHILD) && (fp->ctf_parent == NULL))
return ECTF_NOPARENT;
return (ctf_set_errno (fp, ECTF_NOPARENT));
if (!(fp->ctf_flags & LCTF_RDWR))
{