FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[gdb/tdep] Handle static field in i386_16_byte_align_p

Browse source 
When running test-case on gdb.cp/many-args.exp with target board unix/-m32, I
run into:
...
(gdb) p check_val (ref_val, ref_val, ... , ref_val, ref_val)^M
$1 = false^M
(gdb) FAIL: gdb.cp/many-args.exp: check passing many structures
...

The test source contains struct ss:
...
typedef int v4si __attribute__ ((vector_size (16)));

struct ss
{
  static v4si static_field;
  unsigned char aa;
};
...
and i386_16_byte_align_p returns true for this type.

Fix this by skipping static fields in i386_16_byte_align_p.

Tested on x86_64-linux.

gdb/ChangeLog:

2020-12-04  Tom de Vries  <tdevries@suse.de>

	PR tdep/27007
	* i386-tdep.c (i386_16_byte_align_p): Skip static fields.
This commit is contained in:
Tom de Vries 2020-12-04 13:36:48 +01:00
parent a8d136756b
commit b6a6aa07c5
2 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2020-12-04 Tom de Vries <tdevries@suse.de>
PR tdep/27007
* i386-tdep.c (i386_16_byte_align_p): Skip static fields.
2020-12-03 Simon Marchi <simon.marchi@polymtl.ca>
PR gdb/26876

2
gdb/i386-tdep.c
View file

@ -2644,6 +2644,8 @@ i386_16_byte_align_p (struct type *type)
int i;
for (i = 0; i < type->num_fields (); i++)
{
if (field_is_static (&type->field (i)))
continue;
if (i386_16_byte_align_p (type->field (i).type ()))
return 1;
}