FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix incorrect use of 'is' operator for comparison in python/lib/gdb/command/prompt.py

Browse source 
The 'is' operator is not meant to be used for comparisons. It currently working
is an implementation detail of CPython.  CPython 3.8 has added a SyntaxWarning
for this.
This commit is contained in:
Raul Tambre 2019-05-04 15:48:17 -04:00 • committed by Simon Marchi
parent af97b4161f
commit b6484282f8
2 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
gdb/ChangeLog
View file

@ -1,3 +1,9 @@
2019-05-04 Raul Tambre <raul@tambre.ee>
* python/lib/gdb/prompt.py (_ExtendedPrompt)
<before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
operator for comparison.
2019-05-04 Tom Tromey <tom@tromey.com> 2019-05-04 Tom Tromey <tom@tromey.com>
* psymtab.c (psymbol_name_matches, match_partial_symbol) * psymtab.c (psymbol_name_matches, match_partial_symbol)

4
gdb/python/lib/gdb/command/prompt.py
View file

@ -45,7 +45,7 @@ The currently defined substitutions are:
self.hook_set = False self.hook_set = False
def get_show_string (self, pvalue): def get_show_string (self, pvalue):
if self.value is not '': if self.value:
return "The extended prompt is: " + self.value return "The extended prompt is: " + self.value
else: else:
return "The extended prompt is not set." return "The extended prompt is not set."
@ -57,7 +57,7 @@ The currently defined substitutions are:
return "" return ""
def before_prompt_hook(self, current): def before_prompt_hook(self, current):
if self.value is not '': if self.value:
return gdb.prompt.substitute_prompt(self.value) return gdb.prompt.substitute_prompt(self.value)
else: else:
return None return None