2010-12-31 Michael Snyder <msnyder@vmware.com>

* charset.c: Comment cleanup and long line wrapping.
	* charset.h: Ditto.
	* c-lang.c: Ditto.
	* c-lang.h: Ditto.
	* coff-pe-read.c: Ditto.
	* coff-pe-read.h: Ditto.
	* coffread.c: Ditto.
	* command.h: Ditto.
	* complaints.c: Ditto.
	* complaints.h: Ditto.
	* completer.c: Ditto.
	* completer.h: Ditto.
	* corefile.c: Ditto.
	* corelow.c: Ditto.
	* core-regset.c: Ditto.
	* cp-abi.c: Ditto.
	* cp-abi.h: Ditto.
	* cp-namespace.c: Ditto.
	* cp-support.c: Ditto.
	* cp-support.h: Ditto.
	* cp-valprint.c: Ditto.
	* cp-typeprint.c: Ditto.
	* c-valprint.c: Ditto.
This commit is contained in:
Michael Snyder 2010-12-31 22:59:52 +00:00
parent db09a73fa4
commit aff410f180
24 changed files with 1489 additions and 1076 deletions

View file

@ -59,8 +59,8 @@
static struct core_fns *core_file_fns = NULL;
/* The core_fns for a core file handler that is prepared to read the core
file currently open on core_bfd. */
/* The core_fns for a core file handler that is prepared to read the
core file currently open on core_bfd. */
static struct core_fns *core_vec = NULL;
@ -105,10 +105,10 @@ static struct target_ops core_ops;
/* An arbitrary identifier for the core inferior. */
#define CORELOW_PID 1
/* Link a new core_fns into the global core_file_fns list. Called on gdb
startup by the _initialize routine in each core file register reader, to
register information about each format the the reader is prepared to
handle. */
/* Link a new core_fns into the global core_file_fns list. Called on
gdb startup by the _initialize routine in each core file register
reader, to register information about each format the the reader is
prepared to handle. */
void
deprecated_add_core_fns (struct core_fns *cf)
@ -119,7 +119,7 @@ deprecated_add_core_fns (struct core_fns *cf)
/* The default function that core file handlers can use to examine a
core file BFD and decide whether or not to accept the job of
reading the core file. */
reading the core file. */
int
default_core_sniffer (struct core_fns *our_fns, bfd *abfd)
@ -133,7 +133,7 @@ default_core_sniffer (struct core_fns *our_fns, bfd *abfd)
/* Walk through the list of core functions to find a set that can
handle the core file open on ABFD. Default to the first one in the
list if nothing matches. Returns pointer to set that is
selected. */
selected. */
static struct core_fns *
sniff_core_bfd (bfd *abfd)
@ -142,7 +142,8 @@ sniff_core_bfd (bfd *abfd)
struct core_fns *yummy = NULL;
int matches = 0;;
/* Don't sniff if we have support for register sets in CORE_GDBARCH. */
/* Don't sniff if we have support for register sets in
CORE_GDBARCH. */
if (core_gdbarch && gdbarch_regset_from_core_section_p (core_gdbarch))
return NULL;
@ -173,7 +174,7 @@ sniff_core_bfd (bfd *abfd)
/* The default is to reject every core file format we see. Either
BFD has to recognize it, or we have to provide a function in the
core file handler that recognizes it. */
core file handler that recognizes it. */
int
default_check_format (bfd *abfd)
@ -181,7 +182,7 @@ default_check_format (bfd *abfd)
return (0);
}
/* Attempt to recognize core file formats that BFD rejects. */
/* Attempt to recognize core file formats that BFD rejects. */
static int
gdb_check_format (bfd *abfd)
@ -198,8 +199,8 @@ gdb_check_format (bfd *abfd)
return (0);
}
/* Discard all vestiges of any previous core file and mark data and stack
spaces as empty. */
/* Discard all vestiges of any previous core file and mark data and
stack spaces as empty. */
static void
core_close (int quitting)
@ -209,11 +210,12 @@ core_close (int quitting)
if (core_bfd)
{
int pid = ptid_get_pid (inferior_ptid);
inferior_ptid = null_ptid; /* Avoid confusion from thread stuff */
inferior_ptid = null_ptid; /* Avoid confusion from thread
stuff. */
exit_inferior_silent (pid);
/* Clear out solib state while the bfd is still open. See
comments in clear_solib in solib.c. */
/* Clear out solib state while the bfd is still open. See
comments in clear_solib in solib.c. */
clear_solib ();
xfree (core_data->sections);
@ -236,8 +238,8 @@ core_close_cleanup (void *ignore)
core_close (0/*ignored*/);
}
/* Look for sections whose names start with `.reg/' so that we can extract the
list of threads in a core file. */
/* Look for sections whose names start with `.reg/' so that we can
extract the list of threads in a core file. */
static void
add_to_thread_list (bfd *abfd, asection *asect, void *reg_sect_arg)
@ -271,8 +273,8 @@ add_to_thread_list (bfd *abfd, asection *asect, void *reg_sect_arg)
/* Warning, Will Robinson, looking at BFD private data! */
if (reg_sect != NULL
&& asect->filepos == reg_sect->filepos) /* Did we find .reg? */
inferior_ptid = ptid; /* Yes, make it current */
&& asect->filepos == reg_sect->filepos) /* Did we find .reg? */
inferior_ptid = ptid; /* Yes, make it current. */
}
/* This routine opens and sets up the core file bfd. */
@ -298,9 +300,10 @@ core_open (char *filename, int from_tty)
}
filename = tilde_expand (filename);
if (!IS_ABSOLUTE_PATH(filename))
if (!IS_ABSOLUTE_PATH (filename))
{
temp = concat (current_directory, "/", filename, (char *)NULL);
temp = concat (current_directory, "/",
filename, (char *) NULL);
xfree (filename);
filename = temp;
}
@ -326,15 +329,16 @@ core_open (char *filename, int from_tty)
&& !gdb_check_format (temp_bfd))
{
/* Do it after the err msg */
/* FIXME: should be checking for errors from bfd_close (for one thing,
on error it does not free all the storage associated with the
bfd). */
/* FIXME: should be checking for errors from bfd_close (for one
thing, on error it does not free all the storage associated
with the bfd). */
make_cleanup_bfd_close (temp_bfd);
error (_("\"%s\" is not a core dump: %s"),
filename, bfd_errmsg (bfd_get_error ()));
}
/* Looks semi-reasonable. Toss the old core file and work on the new. */
/* Looks semi-reasonable. Toss the old core file and work on the
new. */
discard_cleanups (old_chain); /* Don't free filename any more */
unpush_target (&core_ops);
@ -358,7 +362,8 @@ core_open (char *filename, int from_tty)
/* Find the data section */
if (build_section_table (core_bfd,
&core_data->sections, &core_data->sections_end))
&core_data->sections,
&core_data->sections_end))
error (_("\"%s\": Can't find sections: %s"),
bfd_get_filename (core_bfd), bfd_errmsg (bfd_get_error ()));
@ -391,7 +396,7 @@ core_open (char *filename, int from_tty)
/* Build up thread list from BFD sections, and possibly set the
current thread to the .reg/NN section matching the .reg
section. */
section. */
bfd_map_over_sections (core_bfd, add_to_thread_list,
bfd_get_section_by_name (core_bfd, ".reg"));
@ -430,16 +435,17 @@ core_open (char *filename, int from_tty)
siggy = bfd_core_file_failing_signal (core_bfd);
if (siggy > 0)
{
/* NOTE: target_signal_from_host() converts a target signal value
into gdb's internal signal value. Unfortunately gdb's internal
value is called ``target_signal'' and this function got the
name ..._from_host(). */
/* NOTE: target_signal_from_host() converts a target signal
value into gdb's internal signal value. Unfortunately gdb's
internal value is called ``target_signal'' and this function
got the name ..._from_host(). */
enum target_signal sig = (core_gdbarch != NULL
? gdbarch_target_signal_from_host (core_gdbarch, siggy)
? gdbarch_target_signal_from_host (core_gdbarch,
siggy)
: target_signal_from_host (siggy));
printf_filtered (_("Program terminated with signal %d, %s.\n"), siggy,
target_signal_to_string (sig));
printf_filtered (_("Program terminated with signal %d, %s.\n"),
siggy, target_signal_to_string (sig));
}
/* Fetch all registers from core file. */
@ -493,7 +499,8 @@ deprecated_core_resize_section_table (int num_added)
NAME section contains, for use in error messages.
If REQUIRED is non-zero, print an error if the core file doesn't
have a section by the appropriate name. Otherwise, just do nothing. */
have a section by the appropriate name. Otherwise, just do
nothing. */
static void
get_core_register_section (struct regcache *regcache,
@ -510,7 +517,8 @@ get_core_register_section (struct regcache *regcache,
xfree (section_name);
if (ptid_get_lwp (inferior_ptid))
section_name = xstrprintf ("%s/%ld", name, ptid_get_lwp (inferior_ptid));
section_name = xstrprintf ("%s/%ld", name,
ptid_get_lwp (inferior_ptid));
else
section_name = xstrdup (name);
@ -518,7 +526,8 @@ get_core_register_section (struct regcache *regcache,
if (! section)
{
if (required)
warning (_("Couldn't find %s registers in core file."), human_name);
warning (_("Couldn't find %s registers in core file."),
human_name);
return;
}
@ -536,7 +545,8 @@ get_core_register_section (struct regcache *regcache,
{
const struct regset *regset;
regset = gdbarch_regset_from_core_section (core_gdbarch, name, size);
regset = gdbarch_regset_from_core_section (core_gdbarch,
name, size);
if (regset == NULL)
{
if (required)
@ -558,7 +568,8 @@ get_core_register_section (struct regcache *regcache,
/* Get the registers out of a core file. This is the machine-
independent part. Fetch_core_registers is the machine-dependent
part, typically implemented in the xm-file for each architecture. */
part, typically implemented in the xm-file for each
architecture. */
/* We just get all the registers, so we don't use regno. */
@ -628,7 +639,7 @@ add_to_spuid_list (bfd *abfd, asection *asect, void *list_p)
{
struct spuid_list *list = list_p;
enum bfd_endian byte_order
= bfd_big_endian (abfd)? BFD_ENDIAN_BIG : BFD_ENDIAN_LITTLE;
= bfd_big_endian (abfd) ? BFD_ENDIAN_BIG : BFD_ENDIAN_LITTLE;
int fd, pos = 0;
sscanf (bfd_section_name (abfd, asect), "SPU/%d/regs%n", &fd, &pos);
@ -647,7 +658,8 @@ add_to_spuid_list (bfd *abfd, asection *asect, void *list_p)
static LONGEST
core_xfer_partial (struct target_ops *ops, enum target_object object,
const char *annex, gdb_byte *readbuf,
const gdb_byte *writebuf, ULONGEST offset, LONGEST len)
const gdb_byte *writebuf, ULONGEST offset,
LONGEST len)
{
switch (object)
{
@ -693,7 +705,8 @@ core_xfer_partial (struct target_ops *ops, enum target_object object,
if (readbuf)
{
/* When the StackGhost cookie is stored in core file, BFD
represents this with a fake section called ".wcookie". */
represents this with a fake section called
".wcookie". */
struct bfd_section *section;
bfd_size_type size;
@ -736,7 +749,8 @@ core_xfer_partial (struct target_ops *ops, enum target_object object,
if (readbuf && annex)
{
/* When the SPU contexts are stored in a core file, BFD
represents this with a fake section called "SPU/<annex>". */
represents this with a fake section called
"SPU/<annex>". */
struct bfd_section *section;
bfd_size_type size;
@ -781,15 +795,17 @@ core_xfer_partial (struct target_ops *ops, enum target_object object,
default:
if (ops->beneath != NULL)
return ops->beneath->to_xfer_partial (ops->beneath, object, annex,
readbuf, writebuf, offset, len);
return ops->beneath->to_xfer_partial (ops->beneath, object,
annex, readbuf,
writebuf, offset, len);
return -1;
}
}
/* If mourn is being called in all the right places, this could be say
`gdb internal error' (since generic_mourn calls breakpoint_init_inferior). */
`gdb internal error' (since generic_mourn calls
breakpoint_init_inferior). */
static int
ignore (struct gdbarch *gdbarch, struct bp_target_info *bp_tgt)
@ -819,7 +835,8 @@ static const struct target_desc *
core_read_description (struct target_ops *target)
{
if (core_gdbarch && gdbarch_core_read_description_p (core_gdbarch))
return gdbarch_core_read_description (core_gdbarch, target, core_bfd);
return gdbarch_core_read_description (core_gdbarch,
target, core_bfd);
return NULL;
}