FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

For Sunos 4.x targets, enable gdb to set breakpoints in shared

Browse source 
library functions before the executable is run. Retrieve dynamic
	symbols from stripped executables.
	* symtab.h (minimal_symbol_type):  Add mst_solib_trampoline type.
	* parse.c (write_exp_msymbol), symmisc.c (dump_msymbols),
	symtab.c (list_symbols):  Handle mst_solib_trampoline.
	* minsyms.c (lookup_minimal_symbol):  Handle mst_solib_trampoline
	for all targets, remove IBM6000_TARGET dependencies.
	* dbxread.c (read_dbx_dynamic_symtab):  New function.
	* dbxread.c (dbx_symfile_read):  Use it.
	* dbxread.c (SET_NAMESTRING):  Set namestring to
	"<bad string table index>" instead of "foo" if the string index is
	corrupt.
	* xcoffread.c (read_xcoff_symtab):  Use mst_solib_trampoline instead
	of mst_unknown.
	* symtab.c (list_symbols):  Take from_tty as parameter and pass it
	to break_command. Handle mst_file_* minimal symbol types.
This commit is contained in:
Peter Schauer 1994-03-15 21:46:32 +00:00
parent f1b4e13156
commit ae6d035d28
5 changed files with 61 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

21
gdb/ChangeLog
View file

@ -1,3 +1,24 @@
Tue Mar 15 13:39:23 1994 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
For Sunos 4.x targets, enable gdb to set breakpoints in shared
library functions before the executable is run. Retrieve dynamic
symbols from stripped executables.
* symtab.h (minimal_symbol_type): Add mst_solib_trampoline type.
* parse.c (write_exp_msymbol), symmisc.c (dump_msymbols),
symtab.c (list_symbols): Handle mst_solib_trampoline.
* minsyms.c (lookup_minimal_symbol): Handle mst_solib_trampoline
for all targets, remove IBM6000_TARGET dependencies.
* dbxread.c (read_dbx_dynamic_symtab): New function.
* dbxread.c (dbx_symfile_read): Use it.
* dbxread.c (SET_NAMESTRING): Set namestring to
"<bad string table index>" instead of "foo" if the string index is
corrupt.
* xcoffread.c (read_xcoff_symtab): Use mst_solib_trampoline instead
of mst_unknown.
* symtab.c (list_symbols): Take from_tty as parameter and pass it
to break_command. Handle mst_file_* minimal symbol types.
* config/i386/tm-i386bsd.h: Give just macro name, not args, to #undef.
Tue Mar 15 11:40:43 1994 Kung Hsu (kung@mexican.cygnus.com) Tue Mar 15 11:40:43 1994 Kung Hsu (kung@mexican.cygnus.com)
* c-exp.y(yylex): fix potential memory overflow. * c-exp.y(yylex): fix potential memory overflow.

33
gdb/minsyms.c
View file

@ -97,9 +97,7 @@ lookup_minimal_symbol (name, objf)
struct minimal_symbol *msymbol; struct minimal_symbol *msymbol;
struct minimal_symbol *found_symbol = NULL; struct minimal_symbol *found_symbol = NULL;
struct minimal_symbol *found_file_symbol = NULL; struct minimal_symbol *found_file_symbol = NULL;
#ifdef IBM6000_TARGET
struct minimal_symbol *trampoline_symbol = NULL; struct minimal_symbol *trampoline_symbol = NULL;
#endif
for (objfile = object_files; for (objfile = object_files;
objfile != NULL && found_symbol == NULL; objfile != NULL && found_symbol == NULL;
@ -125,34 +123,17 @@ lookup_minimal_symbol (name, objf)
found_file_symbol = msymbol; found_file_symbol = msymbol;
break; break;
case mst_unknown: case mst_solib_trampoline:
#ifdef IBM6000_TARGET
/* I *think* all platforms using shared
libraries (and trampoline code) will suffer
this problem. Consider a case where there are
5 shared libraries, each referencing `foo'
with a trampoline entry. When someone wants
to put a breakpoint on `foo' and the only
info we have is minimal symbol vector, we
want to use the real `foo', rather than one
of those trampoline entries. MGO */
/* If a trampoline symbol is found, we prefer to /* If a trampoline symbol is found, we prefer to
keep looking for the *real* symbol. If the keep looking for the *real* symbol. If the
actual symbol not found, then we'll use the actual symbol is not found, then we'll use the
trampoline entry. Sorry for the machine trampoline entry. */
dependent code here, but I hope this will
benefit other platforms as well. For
trampoline entries, we used mst_unknown
earlier. Perhaps we should define a
`mst_trampoline' type?? */
if (trampoline_symbol == NULL) if (trampoline_symbol == NULL)
trampoline_symbol = msymbol; trampoline_symbol = msymbol;
break; break;
#else
/* FALLTHROUGH */ case mst_unknown:
#endif
default: default:
found_symbol = msymbol; found_symbol = msymbol;
break; break;
@ -169,11 +150,9 @@ lookup_minimal_symbol (name, objf)
if (found_file_symbol) if (found_file_symbol)
return found_file_symbol; return found_file_symbol;
/* Symbols for IBM shared library trampolines are next best. */ /* Symbols for shared library trampolines are next best. */
#ifdef IBM6000_TARGET
if (trampoline_symbol) if (trampoline_symbol)
return trampoline_symbol; return trampoline_symbol;
#endif
return NULL; return NULL;
} }

1
gdb/parse.c
View file

@ -378,6 +378,7 @@ write_exp_msymbol (msymbol, text_symbol_type, data_symbol_type)
{ {
case mst_text: case mst_text:
case mst_file_text: case mst_file_text:
case mst_solib_trampoline:
write_exp_elt_type (text_symbol_type); write_exp_elt_type (text_symbol_type);
break; break;

33
gdb/symtab.c
View file

@ -73,7 +73,7 @@ static void
sources_info PARAMS ((char *, int)); sources_info PARAMS ((char *, int));
static void static void
list_symbols PARAMS ((char *, int, int)); list_symbols PARAMS ((char *, int, int, int));
static void static void
output_source_filename PARAMS ((char *, int *)); output_source_filename PARAMS ((char *, int *));
@ -2517,10 +2517,11 @@ sources_info (ignore, from_tty)
we find. */ we find. */
static void static void
list_symbols (regexp, class, bpt) list_symbols (regexp, class, bpt, from_tty)
char *regexp; char *regexp;
int class; int class;
int bpt; int bpt;
int from_tty;
{ {
register struct symtab *s; register struct symtab *s;
register struct partial_symtab *ps; register struct partial_symtab *ps;
@ -2540,9 +2541,15 @@ list_symbols (regexp, class, bpt)
static enum minimal_symbol_type types[] static enum minimal_symbol_type types[]
= {mst_data, mst_text, mst_abs, mst_unknown}; = {mst_data, mst_text, mst_abs, mst_unknown};
static enum minimal_symbol_type types2[] static enum minimal_symbol_type types2[]
= {mst_bss, mst_text, mst_abs, mst_unknown}; = {mst_bss, mst_file_text, mst_abs, mst_unknown};
static enum minimal_symbol_type types3[]
= {mst_file_data, mst_solib_trampoline, mst_abs, mst_unknown};
static enum minimal_symbol_type types4[]
= {mst_file_bss, mst_text, mst_abs, mst_unknown};
enum minimal_symbol_type ourtype = types[class]; enum minimal_symbol_type ourtype = types[class];
enum minimal_symbol_type ourtype2 = types2[class]; enum minimal_symbol_type ourtype2 = types2[class];
enum minimal_symbol_type ourtype3 = types3[class];
enum minimal_symbol_type ourtype4 = types4[class];
if (regexp != NULL) if (regexp != NULL)
{ {
@ -2643,7 +2650,9 @@ list_symbols (regexp, class, bpt)
ALL_MSYMBOLS (objfile, msymbol) ALL_MSYMBOLS (objfile, msymbol)
{ {
if (MSYMBOL_TYPE (msymbol) == ourtype || if (MSYMBOL_TYPE (msymbol) == ourtype ||
MSYMBOL_TYPE (msymbol) == ourtype2) MSYMBOL_TYPE (msymbol) == ourtype2 ||
MSYMBOL_TYPE (msymbol) == ourtype3 ||
MSYMBOL_TYPE (msymbol) == ourtype4)
{ {
if (regexp == NULL || SYMBOL_MATCHES_REGEXP (msymbol)) if (regexp == NULL || SYMBOL_MATCHES_REGEXP (msymbol))
{ {
@ -2710,7 +2719,7 @@ list_symbols (regexp, class, bpt)
strcpy (string, s->filename); strcpy (string, s->filename);
strcat (string, ":"); strcat (string, ":");
strcat (string, SYMBOL_NAME(sym)); strcat (string, SYMBOL_NAME(sym));
break_command (string, 0); break_command (string, from_tty);
} }
} }
else if (!found_in_file) else if (!found_in_file)
@ -2768,7 +2777,9 @@ list_symbols (regexp, class, bpt)
ALL_MSYMBOLS (objfile, msymbol) ALL_MSYMBOLS (objfile, msymbol)
{ {
if (MSYMBOL_TYPE (msymbol) == ourtype || if (MSYMBOL_TYPE (msymbol) == ourtype ||
MSYMBOL_TYPE (msymbol) == ourtype2) MSYMBOL_TYPE (msymbol) == ourtype2 ||
MSYMBOL_TYPE (msymbol) == ourtype3 ||
MSYMBOL_TYPE (msymbol) == ourtype4)
{ {
if (regexp == NULL || SYMBOL_MATCHES_REGEXP (msymbol)) if (regexp == NULL || SYMBOL_MATCHES_REGEXP (msymbol))
{ {
@ -2802,7 +2813,7 @@ variables_info (regexp, from_tty)
char *regexp; char *regexp;
int from_tty; int from_tty;
{ {
list_symbols (regexp, 0, 0); list_symbols (regexp, 0, 0, from_tty);
} }
static void static void
@ -2810,7 +2821,7 @@ functions_info (regexp, from_tty)
char *regexp; char *regexp;
int from_tty; int from_tty;
{ {
list_symbols (regexp, 1, 0); list_symbols (regexp, 1, 0, from_tty);
} }
static void static void
@ -2818,7 +2829,7 @@ types_info (regexp, from_tty)
char *regexp; char *regexp;
int from_tty; int from_tty;
{ {
list_symbols (regexp, 2, 0); list_symbols (regexp, 2, 0, from_tty);
} }
#if 0 #if 0
@ -2827,7 +2838,7 @@ static void
methods_info (regexp) methods_info (regexp)
char *regexp; char *regexp;
{ {
list_symbols (regexp, 3, 0); list_symbols (regexp, 3, 0, from_tty);
} }
#endif /* 0 */ #endif /* 0 */
@ -2837,7 +2848,7 @@ rbreak_command (regexp, from_tty)
char *regexp; char *regexp;
int from_tty; int from_tty;
{ {
list_symbols (regexp, 1, 1); list_symbols (regexp, 1, 1, from_tty);
} }

19
gdb/xcoffread.c
View file

@ -1311,8 +1311,9 @@ function_entry_point:
/* shared library function trampoline code entry point. */ /* shared library function trampoline code entry point. */
else if (CSECT_SCLAS (&main_aux) == XMC_GL) { else if (CSECT_SCLAS (&main_aux) == XMC_GL) {
/* record trampoline code entries as mst_unknown symbol. When we /* record trampoline code entries as mst_solib_trampoline symbol.
lookup mst symbols, we will choose mst_text over mst_unknown. */ When we lookup mst symbols, we will choose mst_text over
mst_solib_trampoline. */
#if 1 #if 1
/* After the implementation of incremental loading of shared /* After the implementation of incremental loading of shared
@ -1323,21 +1324,23 @@ function_entry_point:
consistient with gdb's behaviour on a SUN platform. */ consistient with gdb's behaviour on a SUN platform. */
/* Trying to prefer *real* function entry over its trampoline, /* Trying to prefer *real* function entry over its trampoline,
by assigning `mst_unknown' type to trampoline entries fails. by assigning `mst_solib_trampoline' type to trampoline entries
Gdb treats those entries as chars. FIXME. */ fails. Gdb treats those entries as chars. FIXME. */
/* Recording this entry is necessary. Single stepping relies on /* Recording this entry is necessary. Single stepping relies on
this vector to get an idea about function address boundaries. */ this vector to get an idea about function address boundaries. */
prim_record_minimal_symbol_and_info prim_record_minimal_symbol_and_info
("<trampoline>", cs->c_value, mst_unknown, ("<trampoline>", cs->c_value, mst_solib_trampoline,
(char *)NULL, cs->c_secnum, objfile); (char *)NULL, cs->c_secnum, objfile);
#else #else
/* record trampoline code entries as mst_unknown symbol. When we /* record trampoline code entries as mst_solib_trampoline symbol.
lookup mst symbols, we will choose mst_text over mst_unknown. */ When we lookup mst symbols, we will choose mst_text over
mst_solib_trampoline. */
RECORD_MINIMAL_SYMBOL (cs->c_name, cs->c_value, mst_unknown, RECORD_MINIMAL_SYMBOL (cs->c_name, cs->c_value,
mst_solib_trampoline,
symname_alloced, objfile); symname_alloced, objfile);
#endif #endif
continue; continue;