FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

linux-low: Remove usage of "register" keyword

Browse source 
AFAIK, the register keyword is not relevant today, and clang complains
about it:

/home/emaisin/src/binutils-gdb/gdb/gdbserver/linux-low.c:5873:3: error: 'register' storage class specifier is deprecated and incompatible with C++1z
      [-Werror,-Wdeprecated-register]
  register PTRACE_XFER_TYPE *buffer;
  ^~~~~~~~~

I think we can safely remove it.

gdb/gdbserver/ChangeLog:

	* linux-low.c (linux_read_memory, linux_write_memory): Remove
	usage of "register" keyword.
This commit is contained in:
Simon Marchi 2017-06-17 23:19:08 +02:00
parent 8465943af6
commit ae3e2ccfe7
2 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/gdbserver/ChangeLog
View file

@ -1,3 +1,8 @@
2017-06-17 Simon Marchi <simon.marchi@ericsson.com>
* linux-low.c (linux_read_memory, linux_write_memory): Remove
usage of "register" keyword.
2017-06-17 Simon Marchi <simon.marchi@ericsson.com> 2017-06-17 Simon Marchi <simon.marchi@ericsson.com>
* configure: Re-generate. * configure: Re-generate.

16
gdb/gdbserver/linux-low.c
View file

@ -5870,11 +5870,11 @@ static int
linux_read_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len) linux_read_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len)
{ {
int pid = lwpid_of (current_thread); int pid = lwpid_of (current_thread);
register PTRACE_XFER_TYPE *buffer; PTRACE_XFER_TYPE *buffer;
register CORE_ADDR addr; CORE_ADDR addr;
register int count; int count;
char filename[64]; char filename[64];
register int i; int i;
int ret; int ret;
int fd; int fd;
@ -5958,16 +5958,16 @@ linux_read_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len)
static int static int
linux_write_memory (CORE_ADDR memaddr, const unsigned char *myaddr, int len) linux_write_memory (CORE_ADDR memaddr, const unsigned char *myaddr, int len)
{ {
register int i; int i;
/* Round starting address down to longword boundary. */ /* Round starting address down to longword boundary. */
register CORE_ADDR addr = memaddr & -(CORE_ADDR) sizeof (PTRACE_XFER_TYPE); CORE_ADDR addr = memaddr & -(CORE_ADDR) sizeof (PTRACE_XFER_TYPE);
/* Round ending address up; get number of longwords that makes. */ /* Round ending address up; get number of longwords that makes. */
register int count int count
= (((memaddr + len) - addr) + sizeof (PTRACE_XFER_TYPE) - 1) = (((memaddr + len) - addr) + sizeof (PTRACE_XFER_TYPE) - 1)
/ sizeof (PTRACE_XFER_TYPE); / sizeof (PTRACE_XFER_TYPE);
/* Allocate buffer of that many longwords. */ /* Allocate buffer of that many longwords. */
register PTRACE_XFER_TYPE *buffer = XALLOCAVEC (PTRACE_XFER_TYPE, count); PTRACE_XFER_TYPE *buffer = XALLOCAVEC (PTRACE_XFER_TYPE, count);
int pid = lwpid_of (current_thread); int pid = lwpid_of (current_thread);