FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Change event code to use gdbpy_ref

Browse source 
This changes the event code in the Python layer to use
gdbpy_ref, simplifying the logic in many places.

It also changes evpy_emit_event not to steal a reference to its
argument.  This is simpler to do now that gdbpy_ref is in use;
it's also a reasonable cleanup in its own right.  While doing this I
realized that evpy_emit_event should not be calling gdbpy_print_stack
(all the outermost callers do this if needed), so I removed this as
well.

2017-01-10  Tom Tromey  <tom@tromey.com>

	* python/py-threadevent.c (create_thread_event_object): Use
	gdbpy_ref.
	* python/py-stopevent.c (create_stop_event_object): Simplify.
	(emit_stop_event): Use gdbpy_ref.
	* python/py-signalevent.c (create_signal_event_object): Use
	gdbpy_ref.
	* python/py-newobjfileevent.c (create_new_objfile_event_object)
	(emit_new_objfile_event, create_clear_objfiles_event_object)
	(emit_clear_objfiles_event): Use gdbpy_ref.
	* python/py-infevents.c (create_inferior_call_event_object)
	(create_register_changed_event_object)
	(create_memory_changed_event_object, emit_inferior_call_event)
	(emit_memory_changed_event, emit_register_changed_event): Use
	gdbpy_ref.
	* python/py-exitedevent.c (create_exited_event_object)
	(emit_exited_event): Use gdbpy_ref.
	* python/py-event.h (evpy_emit_event): Remove
	CPYCHECKER_STEALS_REFERENCE_TO_ARG annotation.
	* python/py-event.c (evpy_emit_event): Use gdbpy_ref.
	* python/py-continueevent.c (emit_continue_event): Use
	gdbpy_ref.
	* python/py-breakpoint.c (gdbpy_breakpoint_created)
	(gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
	gdbpy_ref.
	* python/py-bpevent.c (create_breakpoint_event_object): Use
	gdbpy_ref.
This commit is contained in:
Tom Tromey 2016-11-06 20:42:32 -07:00
parent a68ff33e0d
commit abf5651e47
12 changed files with 167 additions and 272 deletions
Download patch file Download diff file Expand all files Collapse all files

27
gdb/python/py-signalevent.c
View file

@ -27,30 +27,23 @@ PyObject *
create_signal_event_object (enum gdb_signal stop_signal)
{
const char *signal_name;
PyObject *signal_name_obj = NULL;
PyObject *signal_event_obj =
create_stop_event_object (&signal_event_object_type);
gdbpy_ref signal_event_obj
(create_stop_event_object (&signal_event_object_type));
if (!signal_event_obj)
goto fail;
if (signal_event_obj == NULL)
return NULL;
signal_name = gdb_signal_to_name (stop_signal);
signal_name_obj = PyString_FromString (signal_name);
gdbpy_ref signal_name_obj (PyString_FromString (signal_name));
if (signal_name_obj == NULL)
goto fail;
if (evpy_add_attribute (signal_event_obj,
return NULL;
if (evpy_add_attribute (signal_event_obj.get (),
"stop_signal",
signal_name_obj) < 0)
goto fail;
Py_DECREF (signal_name_obj);
signal_name_obj.get ()) < 0)
return NULL;
return signal_event_obj;
fail:
Py_XDECREF (signal_name_obj);
Py_XDECREF (signal_event_obj);
return NULL;
return signal_event_obj.release ();
}
GDBPY_NEW_EVENT_TYPE (signal,