FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use gdbarch obstack to allocate the TYPE_NAME string in arch_type

Browse source 
Since the type whose name is being set is now being allocated on the
gdbarch obstack, we should allocate its TYPE_NAME on the obstack too.
This reduces the number of individual valgrind warnings for the command
"gdb gdb" from ~300 to ~150.

Tested on x86_64-unknown-linux-gnu.

gdb/ChangeLog:

	* gdbarch.h (gdbarch_obstack_strdup): Declare.
	* gdbarch.c (gdbarch_obstack_strdup): Define.
	* gdbtypes.c (arch_type): Use it.
This commit is contained in:
Patrick Palka 2015-06-29 10:45:47 -04:00
parent 8f57eec2fb
commit aa78b3b28a
4 changed files with 22 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
gdb/gdbtypes.c
View file

@ -4549,7 +4549,7 @@ arch_type (struct gdbarch *gdbarch,
TYPE_LENGTH (type) = length;
if (name)
TYPE_NAME (type) = xstrdup (name);
TYPE_NAME (type) = gdbarch_obstack_strdup (gdbarch, name);
return type;
}