FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix GCC6 -Wmisleading-indentation issues.

Browse source 
GCC6 will warn about misleading indentation issues like:

gdb/ada-lang.c: In function ‘ada_evaluate_subexp’:
ada-lang.c:11423:9: error: statement is indented as if it were guarded by...
         arg1 = unwrap_value (arg1);
         ^~~~

gdb/ada-lang.c:11421:7: note: ...this ‘else’ clause, but it is not
       else
       ^~~~

In this case it would be a bug except for the fact the if clause already
returned early. So this misindented statement really only got executed
for the else case. But it could easily mislead a reader, so adding a
proper else block is the correct solution.

In case of c-typeprint.c (c_type_print_base) the if statement is indeed
misleadingly indented, but not a bug. Just indent correctly. The inflow.c
(terminal_ours_1) misindented block comes from the removal of an if clause
in commit d9d2d8b which looks correct. Just introduce an else to fixup the
indentation of the block. The linux-record.c misleadingly indented return
statements are just that. Misleading to the reader, but not actual bugs.
Just unindent them so they don't look like they fall under the wrong if
clause.
This commit is contained in:
Mark Wielaard 2016-01-25 20:29:54 +01:00
parent 00acd688ca
commit a579cd9aa8
5 changed files with 39 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

8
gdb/ada-lang.c
View file

@ -11419,9 +11419,11 @@ ada_evaluate_subexp (struct type *expect_type, struct expression *exp,
return value_zero (ada_aligned_type (type), lval_memory);
}
else
arg1 = ada_value_struct_elt (arg1, &exp->elts[pc + 2].string, 0);
arg1 = unwrap_value (arg1);
return ada_to_fixed_value (arg1);
{
arg1 = ada_value_struct_elt (arg1, &exp->elts[pc + 2].string, 0);
arg1 = unwrap_value (arg1);
return ada_to_fixed_value (arg1);
}
case OP_TYPE:
/* The value is not supposed to be used. This is here to make it