FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gas testsuite tidy

Browse source 
This replaces skip and notarget in a number of gas tests with xfail,
the idea being that running tests might expose segmentation faults or
other serious errors even when we don't expect a test to pass.  Doing
so showed a number of cases where tests now pass, which is another
reason to avoid profligate use of notarget and skip.

	* testsuite/gas/all/local-label-overflow.d: Use xfail rather than
	notarget all except hppa.  Comment.
	* testsuite/gas/all/sleb128-2.d: Use xfail rather than notarget.
	* testsuite/gas/all/sleb128-4.d: Likewise.  Don't skip msp430.
	* testsuite/gas/all/sleb128-5.d: Use xfail rather than notarget.
	* testsuite/gas/all/sleb128-7.d: Likewise.
	* testsuite/gas/all/sleb128-9.d: Likewise.
	* testsuite/gas/elf/bignums.d: Likewise.
	* testsuite/gas/elf/group0c.d: Likewise.
	* testsuite/gas/elf/group1a.d: Likewise.
	* testsuite/gas/elf/section-symbol-redef.d: Likewise.
	* testsuite/gas/elf/section15.d: Likewise.
	* testsuite/gas/elf/section4.d: Likewise.
	* testsuite/gas/elf/section7.d: Likewise.
	* testsuite/gas/macros/irp.d: Likewise.
	* testsuite/gas/macros/repeat.d: Likewise.
	* testsuite/gas/macros/rept.d: Likewise.
	* testsuite/gas/macros/test2.d: Likewise.
	* testsuite/gas/macros/vararg.d: Likewise.
	* testsuite/gas/all/string.d: Use xfail rather than skip.
	* testsuite/gas/elf/missing-build-notes.d: Likewise.
	* testsuite/gas/elf/section0.d: Likewise.
	* testsuite/gas/elf/section1.d: Likewise.
	* testsuite/gas/elf/section10.d: Likewise.
	* testsuite/gas/elf/section11.d: Likewise.
	* testsuite/gas/elf/section6.d: Likewise.
	* testsuite/gas/elf/symtab.d: Use xfail rather than skip, adjust hppa.
	* testsuite/gas/elf/symtab.s: Don't start directives in first column.
	* testsuite/gas/macros/test3.d: Don't notarget nds32.
This commit is contained in:
Alan Modra 2021-01-25 22:53:31 +10:30
parent 9886ff0319
commit a45ef9a30b
29 changed files with 64 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

32
gas/ChangeLog
View file

@ -1,3 +1,35 @@
2021-01-26 Alan Modra <amodra@gmail.com>
* testsuite/gas/all/local-label-overflow.d: Use xfail rather than
notarget all except hppa. Comment.
* testsuite/gas/all/sleb128-2.d: Use xfail rather than notarget.
* testsuite/gas/all/sleb128-4.d: Likewise. Don't skip msp430.
* testsuite/gas/all/sleb128-5.d: Use xfail rather than notarget.
* testsuite/gas/all/sleb128-7.d: Likewise.
* testsuite/gas/all/sleb128-9.d: Likewise.
* testsuite/gas/elf/bignums.d: Likewise.
* testsuite/gas/elf/group0c.d: Likewise.
* testsuite/gas/elf/group1a.d: Likewise.
* testsuite/gas/elf/section-symbol-redef.d: Likewise.
* testsuite/gas/elf/section15.d: Likewise.
* testsuite/gas/elf/section4.d: Likewise.
* testsuite/gas/elf/section7.d: Likewise.
* testsuite/gas/macros/irp.d: Likewise.
* testsuite/gas/macros/repeat.d: Likewise.
* testsuite/gas/macros/rept.d: Likewise.
* testsuite/gas/macros/test2.d: Likewise.
* testsuite/gas/macros/vararg.d: Likewise.
* testsuite/gas/all/string.d: Use xfail rather than skip.
* testsuite/gas/elf/missing-build-notes.d: Likewise.
* testsuite/gas/elf/section0.d: Likewise.
* testsuite/gas/elf/section1.d: Likewise.
* testsuite/gas/elf/section10.d: Likewise.
* testsuite/gas/elf/section11.d: Likewise.
* testsuite/gas/elf/section6.d: Likewise.
* testsuite/gas/elf/symtab.d: Use xfail rather than skip, adjust hppa.
* testsuite/gas/elf/symtab.s: Don't start directives in first column.
* testsuite/gas/macros/test3.d: Don't notarget nds32.
2021-01-26 Alan Modra <amodra@gmail.com> 2021-01-26 Alan Modra <amodra@gmail.com>
* testsuite/gas/all/byte.d, * testsuite/gas/all/byte.d,

5
gas/testsuite/gas/all/local-label-overflow.d
View file

@ -1,3 +1,6 @@
#source: local-label-overflow.s #source: local-label-overflow.s
#error_output: local-label-overflow.l #error_output: local-label-overflow.l
#notarget: hppa*-*-* ia64-*-vms mmix-*-* sh-*-pe # Some hppa targets support local labels, others don't. It's a pain to
# enumerate all the combinations so just don't run the test for hppa.
#notarget: hppa*-*-*
#xfail: ia64-*-vms mmix-*-* sh-*-pe

2
gas/testsuite/gas/all/sleb128-2.d
View file

@ -3,7 +3,7 @@
# RISC-V doesn't support .sleb operands that are the difference of two symbols # RISC-V doesn't support .sleb operands that are the difference of two symbols
# because symbol values are not known until after linker relaxation has been # because symbol values are not known until after linker relaxation has been
# performed. # performed.
#notarget : riscv*-*-* #xfail: riscv*-*-*
.*: .* .*: .*

3
gas/testsuite/gas/all/sleb128-4.d
View file

@ -1,10 +1,9 @@
#objdump : -s -j .data -j "\$DATA\$" #objdump : -s -j .data -j "\$DATA\$"
#name : .sleb128 tests (4) #name : .sleb128 tests (4)
#skip: msp430*-*-*
# RISC-V doesn't support .sleb operands that are the difference of two symbols # RISC-V doesn't support .sleb operands that are the difference of two symbols
# because symbol values are not known until after linker relaxation has been # because symbol values are not known until after linker relaxation has been
# performed. # performed.
#notarget: riscv*-*-* #xfail: riscv*-*-*
.*: .* .*: .*

2
gas/testsuite/gas/all/sleb128-5.d
View file

@ -3,7 +3,7 @@
# RISC-V doesn't support .sleb operands that are the difference of two symbols # RISC-V doesn't support .sleb operands that are the difference of two symbols
# because symbol values are not known until after linker relaxation has been # because symbol values are not known until after linker relaxation has been
# performed. # performed.
#notarget : riscv*-*-* #xfail: riscv*-*-*
.*: .* .*: .*

2
gas/testsuite/gas/all/sleb128-7.d
View file

@ -3,7 +3,7 @@
# RISC-V doesn't support .sleb operands that are the difference of two symbols # RISC-V doesn't support .sleb operands that are the difference of two symbols
# because symbol values are not known until after linker relaxation has been # because symbol values are not known until after linker relaxation has been
# performed. # performed.
#notarget: riscv*-*-* #xfail: riscv*-*-*
.*: .* .*: .*

2
gas/testsuite/gas/all/sleb128-9.d
View file

@ -1,5 +1,5 @@
#name: undefined symbols in sleb128 directive #name: undefined symbols in sleb128 directive
#source: sleb128-9.s #source: sleb128-9.s
#error_output: sleb128-9.l #error_output: sleb128-9.l
#notarget: riscv*-* #xfail: riscv*-*

2
gas/testsuite/gas/all/string.d
View file

@ -1,6 +1,6 @@
#objdump : -s -j .data -j "\$DATA\$" #objdump : -s -j .data -j "\$DATA\$"
#name : .strings tests #name : .strings tests
#skip: tic4x-* #xfail: tic4x-*
.*: .* .*: .*

2
gas/testsuite/gas/elf/bignums.d
View file

@ -1,6 +1,6 @@
#readelf: -x .data #readelf: -x .data
#name: bignum byte values #name: bignum byte values
#notarget: rx-* #xfail: rx-*
# The RX target sometimes calls its data section D_1. # The RX target sometimes calls its data section D_1.
# #
# Test that 8-bit and 16-bit constants can be specified via bignums. # Test that 8-bit and 16-bit constants can be specified via bignums.

2
gas/testsuite/gas/elf/group0c.d
View file

@ -1,7 +1,7 @@
#readelf: -sW #readelf: -sW
#name: group section name #name: group section name
#source: group0.s #source: group0.s
#notarget: *-*-solaris* #xfail: *-*-solaris*
#... #...
.*NOTYPE[ ]+LOCAL[ ]+DEFAULT[ ]+[0-9]+[ ]+\.foo_group .*NOTYPE[ ]+LOCAL[ ]+DEFAULT[ ]+[0-9]+[ ]+\.foo_group

2
gas/testsuite/gas/elf/group1a.d
View file

@ -2,7 +2,7 @@
#name: group section with multiple sections of same name (using readelf -SW) #name: group section with multiple sections of same name (using readelf -SW)
#source: group1.s #source: group1.s
# The RX port uses non-standard section names. # The RX port uses non-standard section names.
#notarget: rx-* #xfail: rx-*
#... #...
[ ]*\[.*\][ ]+\.group[ ]+GROUP.* [ ]*\[.*\][ ]+\.group[ ]+GROUP.*

2
gas/testsuite/gas/elf/missing-build-notes.d
View file

@ -1,6 +1,6 @@
# as: --generate-missing-build-notes=yes # as: --generate-missing-build-notes=yes
# objdump: -r # objdump: -r
#skip: mips*-*-openbsd #xfail: mips*-*-openbsd
# Check that the relocations are for increasing addresses... # Check that the relocations are for increasing addresses...

2
gas/testsuite/gas/elf/section-symbol-redef.d
View file

@ -1,5 +1,5 @@
#readelf: -x myseg #readelf: -x myseg
#notarget: bfin-*-* h8300-* #xfail: bfin-*-* h8300-*
Hex dump of section .*: Hex dump of section .*:
0x0+ 2a\s+\* 0x0+ 2a\s+\*

2
gas/testsuite/gas/elf/section0.d
View file

@ -2,7 +2,7 @@
#name: elf section0 #name: elf section0
# The h8300 port issues a warning message for # The h8300 port issues a warning message for
# new sections created without atrributes. # new sections created without atrributes.
#skip: h8300-* #xfail: h8300-*
.*: +file format .* .*: +file format .*

2
gas/testsuite/gas/elf/section1.d
View file

@ -2,7 +2,7 @@
#name: elf section1 #name: elf section1
# The h8300 port issues a warning message for # The h8300 port issues a warning message for
# new sections created without atrributes. # new sections created without atrributes.
#skip: h8300-* #xfail: h8300-*
.*: +file format .* .*: +file format .*

2
gas/testsuite/gas/elf/section10.d
View file

@ -1,7 +1,7 @@
#readelf: -N --wide #readelf: -N --wide
#name: numeric section flags and types #name: numeric section flags and types
# The RX port annoyingly reorders the sections so that they do not match the sequence expected below. # The RX port annoyingly reorders the sections so that they do not match the sequence expected below.
#skip: rx-*-* #xfail: rx-*-*
#... #...
[ ]*\[.*\][ ]+.text [ ]*\[.*\][ ]+.text

4
gas/testsuite/gas/elf/section11.d
View file

@ -2,10 +2,10 @@
#readelf: -S --wide #readelf: -S --wide
#name: Disabling section padding #name: Disabling section padding
# The RX port uses non standard section names. # The RX port uses non standard section names.
#skip: rx-*-* #xfail: rx-*-*
# RISC-V handles alignment via linker relaxation, so object files don't have # RISC-V handles alignment via linker relaxation, so object files don't have
# the expected alignment. # the expected alignment.
#notarget: riscv*-*-* #xfail: riscv*-*-*
#... #...
\[ .\] .text[ ]+PROGBITS[ ]+0+00 0+[0-9a-f]+ 0+0(1|4|5) 00 AX 0 0 16 \[ .\] .text[ ]+PROGBITS[ ]+0+00 0+[0-9a-f]+ 0+0(1|4|5) 00 AX 0 0 16

2
gas/testsuite/gas/elf/section15.d
View file

@ -2,7 +2,7 @@
#name: elf section15 #name: elf section15
# .pushsection always creates the named section, but the # .pushsection always creates the named section, but the
# test harness translates ".text" into "P" for the RX... # test harness translates ".text" into "P" for the RX...
#notarget: rx-* #xfail: rx-*
.*: +file format .* .*: +file format .*

2
gas/testsuite/gas/elf/section4.d
View file

@ -1,7 +1,7 @@
#readelf: --sections #readelf: --sections
#name: label arithmetic with multiple same-name sections #name: label arithmetic with multiple same-name sections
# The RX port uses non-standard section names. # The RX port uses non-standard section names.
#notarget: rx-* #xfail: rx-*
#... #...
[ ]*\[.*\][ ]+\.group[ ]+GROUP.* [ ]*\[.*\][ ]+\.group[ ]+GROUP.*

2
gas/testsuite/gas/elf/section6.d
View file

@ -2,7 +2,7 @@
#name: elf section6 #name: elf section6
# The h8300 port issues a warning message for # The h8300 port issues a warning message for
# new sections created without atrributes. # new sections created without atrributes.
#skip: h8300-* #xfail: h8300-*
.*: +file format .* .*: +file format .*

2
gas/testsuite/gas/elf/section7.d
View file

@ -2,7 +2,7 @@
#name: elf section7 #name: elf section7
# .pushsection always creates the named section, but the # .pushsection always creates the named section, but the
# test harness translates ".text" into "P" for the RX... # test harness translates ".text" into "P" for the RX...
#notarget: rx-* #xfail: rx-*
.*: +file format .* .*: +file format .*

4
gas/testsuite/gas/elf/symtab.d
View file

@ -1,6 +1,6 @@
# The Alpha has its own version of .set. # The Alpha has its own version of .set.
# The HPPA does not output non-global absolute symbols. # hppa SOM does not output non-global absolute symbols.
#skip: alpha-*-* hppa*-*-* #xfail: alpha-*-* [is_som_format]
#readelf: -s #readelf: -s
#name: .set with expression #name: .set with expression

2
gas/testsuite/gas/elf/symtab.s
View file

@ -1,4 +1,4 @@
.text .text
.global foo .global foo
foo: foo:
.set shift, 32 .set shift, 32

2
gas/testsuite/gas/macros/irp.d
View file

@ -1,7 +1,7 @@
#objdump: -r #objdump: -r
#name: macro irp #name: macro irp
#darwin (mach-o) reverses relocs. #darwin (mach-o) reverses relocs.
#notarget: *-*-darwin* nds32*-*-* #xfail: *-*-darwin* nds32*-*-*
.*: +file format .* .*: +file format .*

2
gas/testsuite/gas/macros/repeat.d
View file

@ -1,7 +1,7 @@
#objdump: -r #objdump: -r
#name: nested irp/irpc/rept #name: nested irp/irpc/rept
# darwin (mach-o) reverse relocs. # darwin (mach-o) reverse relocs.
#notarget: *-*-darwin* #xfail: *-*-darwin*
.*: +file format .* .*: +file format .*

2
gas/testsuite/gas/macros/rept.d
View file

@ -1,7 +1,7 @@
#objdump: -r #objdump: -r
#name: macro rept #name: macro rept
#darwin (mach-o) reverses relocs. #darwin (mach-o) reverses relocs.
#notarget: *-*-darwin* nds32*-*-* #xfail: *-*-darwin* nds32*-*-*
.*: +file format .* .*: +file format .*

2
gas/testsuite/gas/macros/test2.d
View file

@ -1,7 +1,7 @@
#objdump: -r #objdump: -r
#name: macro test 2 #name: macro test 2
# darwin(mach-o) reverses the order of relocs. # darwin(mach-o) reverses the order of relocs.
#notarget: *-*-darwin* #xfail: *-*-darwin*
.*: +file format .* .*: +file format .*

1
gas/testsuite/gas/macros/test3.d
View file

@ -1,6 +1,5 @@
#objdump: -r #objdump: -r
#name: macro test 3 #name: macro test 3
#notarget: nds32*-*-*
.*: +file format .* .*: +file format .*

2
gas/testsuite/gas/macros/vararg.d
View file

@ -1,7 +1,7 @@
#objdump: -r #objdump: -r
#name: macro vararg #name: macro vararg
# darwin (mach-o) reverses relocs. # darwin (mach-o) reverses relocs.
#notarget: *-*-darwin* #xfail: *-*-darwin*
.*: +file format .* .*: +file format .*