FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove unnecessary ternary operator in m32c-tdep.c

Browse source 
Bug 17816 pointed out a useless use of the ternary operator:

  case 0x0: sd.reg = (size == 1 ? &st->r0 : &st->r0); break;

I believe that this is right.  If size is 1, the instruction refers to
part of r0, while if size is 2, the instruction refers to the whole of
r0.

gdb/ChangeLog:

	PR gdb/17816
	* m32c-tdep.c (m32c_decode_srcdest4): Remove unnecessary ternary
	operator.
This commit is contained in:
Simon Marchi 2018-08-21 10:47:47 -04:00
parent 06d743b723
commit a4497d2f84
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
gdb/ChangeLog
View file

@ -1,3 +1,9 @@
2018-08-21 Simon Marchi <simon.marchi@ericsson.com>
PR gdb/17816
* m32c-tdep.c (m32c_decode_srcdest4): Remove unnecessary ternary
operator.
2018-08-19 Simon Marchi <simon.marchi@polymtl.ca> 2018-08-19 Simon Marchi <simon.marchi@polymtl.ca>
* solib-svr4.c (svr4_exec_displacement): Fix formatting. * solib-svr4.c (svr4_exec_displacement): Fix formatting.

2
gdb/m32c-tdep.c
View file

@ -1236,7 +1236,7 @@ m32c_decode_srcdest4 (struct m32c_pv_state *st,
switch (code) switch (code)
{ {
case 0x0: sd.reg = (size == 1 ? &st->r0 : &st->r0); break; case 0x0: sd.reg = &st->r0; break;
case 0x1: sd.reg = (size == 1 ? &st->r0 : &st->r1); break; case 0x1: sd.reg = (size == 1 ? &st->r0 : &st->r1); break;
case 0x2: sd.reg = (size == 1 ? &st->r1 : &st->r2); break; case 0x2: sd.reg = (size == 1 ? &st->r1 : &st->r2); break;
case 0x3: sd.reg = (size == 1 ? &st->r1 : &st->r3); break; case 0x3: sd.reg = (size == 1 ? &st->r1 : &st->r3); break;