FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Python: Remove ptid from gdb.Record interface

Browse source 
As discussed here: https://sourceware.org/ml/gdb-patches/2017-04/msg00166.html
This commit is contained in:
Tim Wiederhake 2017-05-02 11:35:54 +02:00
parent ae20e79ae8
commit a3be24ad59
6 changed files with 13 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2017-05-01 Tim Wiederhake <tim.wiederhake@intel.com>
* python/py-record.c (recpy_ptid): Remove.
(recpy_record_getset): Remove recpy_ptid.
2017-05-01 Tim Wiederhake <tim.wiederhake@intel.com>
* btrace.c (btrace_fetch): Set inferior_ptid.

4
gdb/doc/ChangeLog
View file

@ -1,3 +1,7 @@
2017-05-01 Tim Wiederhake <tim.wiederhake@intel.com>
* python.texi (Recording in Python): Remove Record.ptid defvar.
2017-04-21 Simon Marchi <simon.marchi@ericsson.com>
* gdb.texinfo (GDB/MI Thread Information): Add missing

7
gdb/doc/python.texi
View file

@ -3110,13 +3110,6 @@ currently active. All record objects become invalid after this call.
A @code{gdb.Record} object has the following attributes:
@defvar Record.ptid
ID of the thread associated with this object as a tuple of three integers. The
first is the Process ID (PID); the second is the Lightweight Process ID (LWPID),
and the third is the Thread ID (TID). Either the LWPID or TID may be 0, which
indicates that the operating system does not use that identifier.
@end defvar
@defvar Record.method
A string with the current recording method, e.g.@: @code{full} or
@code{btrace}.

11
gdb/python/py-record.c
View file

@ -29,16 +29,6 @@ static PyTypeObject recpy_record_type = {
PyVarObject_HEAD_INIT (NULL, 0)
};
/* Implementation of record.ptid. */
static PyObject *
recpy_ptid (PyObject *self, void* closure)
{
const recpy_record_object * const obj = (recpy_record_object *) self;
return gdbpy_create_ptid_object (obj->ptid);
}
/* Implementation of record.method. */
static PyObject *
@ -161,7 +151,6 @@ Rewind to given location."},
/* Record member list. */
static gdb_PyGetSetDef recpy_record_getset[] = {
{ "ptid", recpy_ptid, NULL, "Current thread.", NULL },
{ "method", recpy_method, NULL, "Current recording method.", NULL },
{ "format", recpy_format, NULL, "Current recording format.", NULL },
{ "replay_position", recpy_replay_position, NULL, "Current replay position.",

4
gdb/testsuite/ChangeLog
View file

@ -1,3 +1,7 @@
2017-05-01 Tim Wiederhake <tim.wiederhake@intel.com>
* gdb.python/py-record-btrace.exp: Remove Record.ptid test.
2017-05-01 Tim Wiederhake <tim.wiederhake@intel.com>
* gdb.python/py-record-btrace-threads.c: New file.

1
gdb/testsuite/gdb.python/py-record-btrace.exp
View file

@ -59,7 +59,6 @@ with_test_prefix "preopened record btrace" {
with_test_prefix "prepare record" {
gdb_test_no_output "python r = gdb.start_recording(\"btrace\")"
gdb_test "python print(len(r.ptid))" "3"
gdb_test "python print(r.method)" "btrace"
gdb_test "python print(r.format)" "pt|bts"
gdb_test "stepi 100" ".*"