FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb/testsuite: use gdb_test_no_output instead of send_gdb

Browse source 
I noticed gdb.base/ptype-offsets.exp failing occasionally, this was
due to lines like this in the test script:

  send_gdb "set print type hex on\n"

As this does not match the '(gdb)' prompt that is produced, the prompt
would sometimes be matched against the next test, causing the next
test to think its output was missing and fail.

Fix this by switching to:

  gdb_test_no_output "set print type hex on"

gdb/testsuite/ChangeLog:

	* gdb.base/ptype-offsets.exp: Replace use of send_gdb with
	gdb_test_no_output.
This commit is contained in:
Andrew Burgess 2021-05-07 22:14:27 +01:00
parent 91e3c425d6
commit a3237c7cc7
2 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2021-05-07 Andrew Burgess <andrew.burgess@embecosm.com>
* gdb.base/ptype-offsets.exp: Replace use of send_gdb with
gdb_test_no_output.
2021-05-07 Simon Marchi <simon.marchi@polymtl.ca>
* Re-format all Python files using black.

4
gdb/testsuite/gdb.base/ptype-offsets.exp
View file

@ -413,7 +413,7 @@ gdb_test "ptype/o empty_member" \
with_test_prefix "with_hex_default" {
# Test setting default display to hex
send_gdb "set print type hex on\n"
gdb_test_no_output "set print type hex on"
gdb_test "show print type hex" \
"Display of struct members offsets and sizes in hexadecimal is on"
@ -467,5 +467,5 @@ with_test_prefix "with_hex_default" {
" \}"]]
# restore
send_gdb "set print type hex off\n"
gdb_test_no_output "set print type hex off"
}