FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update comments to operator_check

Browse source 
Hello,
I happen to read the code and find the comments to operator_check are
incorrect.  This patch is to fix the comments per my understanding.
The comments and field operator_check was added by this patch

  https://sourceware.org/ml/gdb-patches/2010-04/msg00556.html

but the inconsistency between code and comments wasn't pointed out during
the review.

gdb:

2014-07-30  Yao Qi  <yao@codesourcery.com>

	* parser-defs.h (struct exp_descriptor) <operator_check>: Update
	comments.
	* parse.c (exp_iterate): Update comments.
This commit is contained in:
Yao Qi 2014-07-25 19:35:23 +08:00
parent 976411d6b6
commit a1c7835a2f
3 changed files with 20 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

16
gdb/parser-defs.h
View file

@ -341,14 +341,14 @@ struct exp_descriptor
the number of subexpressions it takes. */
void (*operator_length) (const struct expression*, int, int*, int *);
/* Call TYPE_FUNC and OBJFILE_FUNC for any TYPE and OBJFILE found being
referenced by the single operator of EXP at position POS. Operator
parameters are located at positive (POS + number) offsets in EXP.
The functions should never be called with NULL TYPE or NULL OBJFILE.
Functions should get passed an arbitrary caller supplied DATA pointer.
If any of the functions returns non-zero value then (any other) non-zero
value should be immediately returned to the caller. Otherwise zero
should be returned. */
/* Call OBJFILE_FUNC for any objfile found being referenced by the
single operator of EXP at position POS. Operator parameters are
located at positive (POS + number) offsets in EXP. OBJFILE_FUNC
should never be called with NULL OBJFILE. OBJFILE_FUNC should
get passed an arbitrary caller supplied DATA pointer. If it
returns non-zero value then (any other) non-zero value should be
immediately returned to the caller. Otherwise zero should be
returned. */
int (*operator_check) (struct expression *exp, int pos,
int (*objfile_func) (struct objfile *objfile,
void *data),