FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Allow hiding of some filtered frames

Browse source 
When a frame filter elides some frames, they are still printed by
"bt", indented a few spaces.  PR backtrace/15582 notes that it would
be nice for users if elided frames could simply be dropped.  This
patch adds this capability.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	PR backtrace/15582:
	* stack.c (backtrace_command): Parse "hide" argument.
	* python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
	* extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
	constant.

gdb/doc/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	PR backtrace/15582:
	* gdb.texinfo (Backtrace): Mention "hide" argument.

gdb/testsuite/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	PR backtrace/15582:
	* gdb.python/py-framefilter.exp: Add "bt hide" test.
This commit is contained in:
Tom Tromey 2017-04-23 11:03:57 -06:00
parent 1cf7e64086
commit 978d6c756f
8 changed files with 57 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

50
gdb/python/py-framefilter.c
View file

@ -1238,37 +1238,37 @@ py_print_frame (PyObject *filter, frame_filter_flags flags,
return EXT_LANG_BT_ERROR;
}
{
/* Finally recursively print elided frames, if any. */
gdbpy_ref<> elided (get_py_iter_from_func (filter, "elided"));
if (elided == NULL)
return EXT_LANG_BT_ERROR;
if ((flags & PRINT_HIDE) == 0)
{
/* Finally recursively print elided frames, if any. */
gdbpy_ref<> elided (get_py_iter_from_func (filter, "elided"));
if (elided == NULL)
return EXT_LANG_BT_ERROR;
if (elided != Py_None)
{
PyObject *item;
if (elided != Py_None)
{
PyObject *item;
ui_out_emit_list inner_list_emiter (out, "children");
ui_out_emit_list inner_list_emiter (out, "children");
if (! out->is_mi_like_p ())
indent++;
if (! out->is_mi_like_p ())
indent++;
while ((item = PyIter_Next (elided.get ())))
{
gdbpy_ref<> item_ref (item);
while ((item = PyIter_Next (elided.get ())))
{
gdbpy_ref<> item_ref (item);
enum ext_lang_bt_status success = py_print_frame (item, flags,
args_type, out,
indent,
levels_printed);
enum ext_lang_bt_status success
= py_print_frame (item, flags, args_type, out, indent,
levels_printed);
if (success == EXT_LANG_BT_ERROR)
return EXT_LANG_BT_ERROR;
}
if (item == NULL && PyErr_Occurred ())
return EXT_LANG_BT_ERROR;
}
}
if (success == EXT_LANG_BT_ERROR)
return EXT_LANG_BT_ERROR;
}
if (item == NULL && PyErr_Occurred ())
return EXT_LANG_BT_ERROR;
}
}
return EXT_LANG_BT_COMPLETED;
}