FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[gdb/python] Fix cpychecker error in recpy_bt_goto

Browse source 
When using cpychecker, we run into this error:
...
gdb/python/py-record-btrace.c: \
  In function ‘PyObject* recpy_bt_goto(PyObject*, PyObject*)’:
gdb/python/py-record-btrace.c:783:25: error: Mismatching type in call to \
  PyArg_ParseTuple with format code "O" [-Werror]
   if (!PyArg_ParseTuple (args, "O", &obj))
  argument 3 ("&obj") had type
    "const struct recpy_element_object * *"
  but was expecting
    "struct PyObject * *"
  for format code "O"
...

Fix this by using a new variable of the expected type instead.

Build and reg-tested on x86_64-linux.

2018-10-05  Tom de Vries  <tdevries@suse.de>

	* python/py-record-btrace.c (recpy_bt_goto): Fix type mismatch in
	PyArg_ParseTuple call.
This commit is contained in:
Tom de Vries 2018-10-02 21:47:37 +02:00
parent d2f7dcb218
commit 96b1ad866b
2 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
gdb/python/py-record-btrace.c
View file

@ -776,15 +776,17 @@ recpy_bt_goto (PyObject *self, PyObject *args)
const recpy_record_object * const record = (recpy_record_object *) self;
thread_info *const tinfo = record->thread;
const recpy_element_object *obj;
PyObject *parse_obj;
if (tinfo == NULL || btrace_is_empty (tinfo))
return PyErr_Format (gdbpy_gdb_error, _("Empty branch trace."));
if (!PyArg_ParseTuple (args, "O", &obj))
if (!PyArg_ParseTuple (args, "O", &parse_obj))
return NULL;
if (Py_TYPE (obj) != &recpy_insn_type)
if (Py_TYPE (parse_obj) != &recpy_insn_type)
return PyErr_Format (PyExc_TypeError, _("Argument must be instruction."));
obj = (const recpy_element_object *) parse_obj;
TRY
{