FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[gdb] Make variable printed bool in info_checkpoints_command

Browse source 
While reading info_checkpoints_command, I noticed variable printed:
...
  const fork_info *printed = NULL;
  ...
  for (const fork_info &fi : fork_list)
    {
      if (requested > 0 && fi.num != requested)
	continue;

      printed = &fi;
      ...
    }
  if (printed == NULL)
...
has pointer type, but is just used as bool.

Make this explicit by changing the variable type to bool.

Tested on x86_64-linux.

Approved-By: Kevin Buettner <kevinb@redhat.com>
This commit is contained in:
Tom de Vries 2024-01-10 11:27:34 +01:00
parent 42bd6b5fd4
commit 94e037b46c
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gdb/linux-fork.c
View file

@ -583,7 +583,7 @@ info_checkpoints_command (const char *arg, int from_tty)
{
struct gdbarch *gdbarch = get_current_arch ();
int requested = -1;
const fork_info *printed = NULL;
bool printed = false;
if (arg && *arg)
requested = (int) parse_and_eval_long (arg);
@ -592,8 +592,8 @@ info_checkpoints_command (const char *arg, int from_tty)
{
if (requested > 0 && fi.num != requested)
continue;
printed = true;
printed = &fi;
if (fi.ptid == inferior_ptid)
gdb_printf ("* ");
else
@ -623,7 +623,8 @@ info_checkpoints_command (const char *arg, int from_tty)
gdb_putc ('\n');
}
if (printed == NULL)
if (!printed)
{
if (requested > 0)
gdb_printf (_("No checkpoint number %d.\n"), requested);