FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ld: Set non_ir_ref_regular for --undefined SYMBOL

Browse source 
Set non_ir_ref_regular to TRUE for symbols forced into the output file
so that they won't be removed by garbage collection with LTO.

	PR ld/23309
	* ldlang.c (insert_undefined): Set non_ir_ref_regular to TRUE.
	* plugin.c (is_visible_from_outside): Don't scan entry_symbol.
	* testsuite/ld-plugin/pr23309.c: New file.
	* testsuite/ld-plugin/pr23309.d: Likewise.
This commit is contained in:
H.J. Lu 2018-07-04 06:27:58 -07:00
parent b14b7ff14f
commit 94d401b8b8
6 changed files with 26 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ld/ChangeLog
View file

@ -1,3 +1,11 @@
2018-07-04 H.J. Lu <hongjiu.lu@intel.com>
PR ld/23309
* ldlang.c (insert_undefined): Set non_ir_ref_regular to TRUE.
* plugin.c (is_visible_from_outside): Don't scan entry_symbol.
* testsuite/ld-plugin/pr23309.c: New file.
* testsuite/ld-plugin/pr23309.d: Likewise.
2018-07-04 H.J. Lu <hongjiu.lu@intel.com>
PR ld/23358

1
ld/ldlang.c
View file

@ -3413,6 +3413,7 @@ insert_undefined (const char *name)
{
h->type = bfd_link_hash_undefined;
h->u.undef.abfd = NULL;
h->non_ir_ref_regular = TRUE;
if (is_elf_hash_table (link_info.hash))
((struct elf_link_hash_entry *) h)->mark = 1;
bfd_link_add_undef (link_info.hash, h);

7
ld/plugin.c
View file

@ -625,8 +625,6 @@ static inline bfd_boolean
is_visible_from_outside (struct ld_plugin_symbol *lsym,
struct bfd_link_hash_entry *blhe)
{
struct bfd_sym_chain *sym;
if (bfd_link_relocatable (&link_info))
return TRUE;
if (blhe->non_ir_ref_dynamic
@ -658,11 +656,6 @@ is_visible_from_outside (struct ld_plugin_symbol *lsym,
|| lsym->visibility == LDPV_PROTECTED);
}
for (sym = &entry_symbol; sym != NULL; sym = sym->next)
if (sym->name
&& strcmp (sym->name, blhe->root.string) == 0)
return TRUE;
return FALSE;
}

4
ld/testsuite/ld-plugin/lto.exp
View file

@ -242,6 +242,10 @@ set lto_compile_elf_tests [list \
[list "Compile 8b" \
"" "-flto -O2" \
{lto-8b.c} {} ""] \
[list "PR ld/23309" \
"-O2 -flto -fuse-linker-plugin -fvisibility=hidden -ffunction-sections -Wl,--gc-sections,-u,KeepMe" \
"-O2 -flto -fuse-linker-plugin -fvisibility=hidden -ffunction-sections" \
{pr23309.c} {{"nm" {} "pr23309.d"}} "pr23309.exe" "c"] \
]
# Generate input files for complex LTO tests for ELF.

10
ld/testsuite/ld-plugin/pr23309.c Normal file
View file

@ -0,0 +1,10 @@
int
main (void)
{
return 0;
}
void
KeepMe (void)
{
}

3
ld/testsuite/ld-plugin/pr23309.d Normal file
View file

@ -0,0 +1,3 @@
#...
[0-9a-f]+ . _?KeepMe
#pass